Message-ID: <1344844219.4126.24.camel@mattotaupa>
Subject: Re: [PATCH] drm/radeon: Include swiotlb.h if SWIOTLB configured.
From: Paul Menzel <paulepanter@users.sourceforge.net>
To: Huacai Chen <chenhuacai@gmail.com>
Cc: Michel =?ISO-8859-1?Q?D=E4nzer?= <michel@daenzer.net>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        Fuxin Zhang <zhangfx@lemote.com>, Huacai Chen <chenhc@lemote.com>,
        Hongliang Tao <taohl@lemote.com>, Hua Yan <yanh@lemote.com>
Date: Mon, 13 Aug 2012 09:50:19 +0200
In-Reply-To: <CAAhV-H5ZA0kC-0kNag-e35Oh9wYh9nZK3OY3GOS2hkhkSn1Jzg@mail.gmail.com>
References: <1344823753-28780-1-git-send-email-chenhc@lemote.com>
	 <1344841259.4126.4.camel@mattotaupa>
	 <CAAhV-H5ZA0kC-0kNag-e35Oh9wYh9nZK3OY3GOS2hkhkSn1Jzg@mail.gmail.com>
Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature";
	boundary="=-T4wP3A8qz30o0j9etNiI"
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2605
Lines: 88


--=-T4wP3A8qz30o0j9etNiI
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Dear Huacai,


Am Montag, den 13.08.2012, 15:16 +0800 schrieb Huacai Chen:
> On Mon, Aug 13, 2012 at 3:00 PM, Paul Menzel wrote:

> > thanks for your patch.
> >
> > Firstly, is Chen your first or last name? If it is your first name, you=
r
> > From address should be switched.
> Chen is may last name.

I am sorry then.

> > Am Montag, den 13.08.2012, 10:09 +0800 schrieb Huacai Chen:
> >> When SWIOTLB is configured, if without this patch kernel compilation
> >> fails.
> >
> > Secondly, could you please always paste part of the error message into
> > the commit message so that people hitting this problem and searching fo=
r
> > it on the WWW have a higher chance finding your patch.
> >
> OK, I'll paste error message.
>=20
> > Thirdly, do you know why this was not caught beforehand and compilation
> > worked before?
> Maybe radeon is mostly used on X86 and swiotlb.h is included
> indirectly on X86 platform. This patch is split from my MIPS patchset,
> on MIPS machines compilation always failed.

Ah, I thought your patches had already been submitted.

> >> Signed-off-by: Huacai Chen <chenhc@lemote.com>
> >
> > Lastly, the addresses in your From line and Signed-off-by line disagree=
.
> > You can easily fix that, by adding
> My patch is generated by git format-patch and there is surely a From
> line in the beginning (from chenhc@lemote.com),

It should be `From: Huacai Chen <chenhc@lemote.com>`.

> but the mail is sent out by gmail, so I don't know how to make From
> line and Signed-off-by agree.

Do you copy the content of the file created by `git format-patch` into
the Gmail Web compositor?

If yes, just do not delete the `From` *and* `Date` lines from the
beginning as for example Alex Deucher is doing [1].

[=E2=80=A6]


Thanks,

Paul


[1] http://lists.freedesktop.org/archives/dri-devel/2012-July/025200.html

--=-T4wP3A8qz30o0j9etNiI
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEABECAAYFAlAosbsACgkQPX1aK2wOHVjmPACfWUl29xSCKkGyWo70uITrQ/FR
k0IAnijKeFTHeJ5EurRtIH7VtFVVYn+p
=gLX0
-----END PGP SIGNATURE-----

--=-T4wP3A8qz30o0j9etNiI--

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/