Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753458Ab2HNIDd (ORCPT ); Tue, 14 Aug 2012 04:03:33 -0400 Received: from mail-vb0-f46.google.com ([209.85.212.46]:40393 "EHLO mail-vb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751801Ab2HNIDZ (ORCPT ); Tue, 14 Aug 2012 04:03:25 -0400 MIME-Version: 1.0 In-Reply-To: References: <5028CDED.2020307@samsung.com> <000e01cd79c2$4c6a8cc0$e53fa640$%cy.chen@samsung.com> Date: Tue, 14 Aug 2012 10:03:24 +0200 Message-ID: Subject: Re: [PATCH] mmc: card: Skip secure option for MoviNAND. From: Linus Walleij To: Namjae Jeon Cc: IAN CHEN , cjb@laptop.org, adrian.hunter@intel.com, subhashj@codeaurora.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, d.j.shin@samsung.com, jongtae22.kim@samsung.com, kyungmin.park@samsung.com, jh80.chung@samsung.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 592 Lines: 17 On Tue, Aug 14, 2012 at 5:51 AM, Namjae Jeon wrote: > So Would you change flag name to be neutral ? MMC_QUIRK_SEC_ERASE_TRIM_BROKEN It appears that mmc_blk_issue_secdiscard_rq() always use both erase and trim (given helpers like mmc_can_secure_erase_trim()) so if either is broken we set this flag. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/