Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754044Ab2HNITL (ORCPT ); Tue, 14 Aug 2012 04:19:11 -0400 Received: from mail-vc0-f174.google.com ([209.85.220.174]:59822 "EHLO mail-vc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753321Ab2HNITJ (ORCPT ); Tue, 14 Aug 2012 04:19:09 -0400 MIME-Version: 1.0 In-Reply-To: <1344527635-6163-3-git-send-email-lee.jones@linaro.org> References: <1344527635-6163-1-git-send-email-lee.jones@linaro.org> <1344527635-6163-3-git-send-email-lee.jones@linaro.org> Date: Tue, 14 Aug 2012 10:19:08 +0200 Message-ID: Subject: Re: [PATCH 2/8] irqdomain: Take interrupt-parent property into account if specified From: Linus Walleij To: Lee Jones Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, linus.walleij@stericsson.com, arnd@arndb.de, broonie@opensource.wolfsonmicro.com, Benjamin Herrenschmidt , Grant Likely Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1101 Lines: 26 On Thu, Aug 9, 2012 at 5:53 PM, Lee Jones wrote: > irq_find_host() currently ignores the 'interrupt-parent' property > even if it's specified in the Device Tree. Meaning that a node can > match to a domain in its hierarchy even if it doesn't belong to it. > By searching for the parent first using of_irq_find_parent() we > insist that the 'interrupt-parent' property is taken into account > ensuring a greater chance of returning the correct domain. > > CC: Benjamin Herrenschmidt > CC: Grant Likely > Signed-off-by: Lee Jones This (with 1/8) is the right solution. Thanks, and I think Mark may want to look at this too since I recognize he asked you to work in this direction. Acked-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/