Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755598Ab2HNJ5A (ORCPT ); Tue, 14 Aug 2012 05:57:00 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:47846 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752394Ab2HNJ47 (ORCPT ); Tue, 14 Aug 2012 05:56:59 -0400 Message-ID: <502A20DD.5030707@ti.com> Date: Tue, 14 Aug 2012 11:56:45 +0200 From: Benoit Cousson Organization: Texas Instruments User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0 MIME-Version: 1.0 To: Sourav Poddar CC: , , , , Felipe Balbi , Santosh Shilimkar Subject: Re: [PATCHv2 2/4] arm/dts: omap5-evm: Add tmp102 sensor support References: <1344852313-30484-1-git-send-email-sourav.poddar@ti.com> <1344852313-30484-3-git-send-email-sourav.poddar@ti.com> In-Reply-To: <1344852313-30484-3-git-send-email-sourav.poddar@ti.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1418 Lines: 43 On 08/13/2012 12:05 PM, Sourav Poddar wrote: > Add tmp102 temperature sensor data in omap5 evm dts file. > > Tested on omap5430 evm with 3.5 custom kernel. > > Cc: Benoit Cousson > Cc: Felipe Balbi > Cc: Santosh Shilimkar > Acked-by: Felipe Balbi > Signed-off-by: Sourav Poddar > --- > arch/arm/boot/dts/omap5-evm.dts | 9 +++++++++ > 1 files changed, 9 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/boot/dts/omap5-evm.dts b/arch/arm/boot/dts/omap5-evm.dts > index 200c39a..45a8aeb 100644 > --- a/arch/arm/boot/dts/omap5-evm.dts > +++ b/arch/arm/boot/dts/omap5-evm.dts > @@ -18,3 +18,12 @@ > reg = <0x80000000 0x40000000>; /* 1 GB */ > }; > }; > + > +&i2c4 { > + clock-frequency = <400000>; Have you checked if we cannot run at faster speed? Reducing the speed will impact every devices on the bus. It might be needed, I just wanted to be sure. You should maybe just add a small comment to explain what the device is doing with potentially a link to the HW spec if available. The same comments are applicable to the bmp085 patch. Regards, Benoit -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/