Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755644Ab2HNKBt (ORCPT ); Tue, 14 Aug 2012 06:01:49 -0400 Received: from ch1ehsobe002.messaging.microsoft.com ([216.32.181.182]:32541 "EHLO ch1outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752645Ab2HNKBr (ORCPT ); Tue, 14 Aug 2012 06:01:47 -0400 X-Forefront-Antispam-Report: CIP:70.37.183.190;KIP:(null);UIP:(null);IPV:NLI;H:mail.freescale.net;RD:none;EFVD:NLI X-SpamScore: -3 X-BigFish: VS-3(zz98dI9371I1432Izz1202hzz8275bhz2dh2a8h668h839h944hd25hf0ah107ah) Date: Tue, 14 Aug 2012 18:01:41 +0800 From: Zhao Chenhui To: Tabi Timur-B04825 CC: Zhao Chenhui-B35336 , "linuxppc-dev@lists.ozlabs.org" , "galak@kernel.crashing.org" , "linux-kernel@vger.kernel.org" , Li Yang-R58472 , Subject: Re: [PATCH 2/4] fsl_pmc: Add API to enable device as wakeup event source Message-ID: <20120814100141.GB21028@localhost.localdomain> References: <1344329006-10645-1-git-send-email-chenhui.zhao@freescale.com> <1344329006-10645-2-git-send-email-chenhui.zhao@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-OriginatorOrg: freescale.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2310 Lines: 76 On Sat, Aug 11, 2012 at 08:19:43AM -0500, Tabi Timur-B04825 wrote: > On Tue, Aug 7, 2012 at 3:43 AM, Zhao Chenhui wrote: > > > +int mpc85xx_pmc_set_wake(struct device *dev, bool enable) > > +{ > > + int ret = 0; > > + struct device_node *clk_np; > > + const u32 *prop; > > + u32 pmcdr_mask; > > + > > + if (!pmc_regs) { > > + pr_err("%s: PMC is unavailable\n", __func__); > > You have a 'struct device', so please use dev_err instead. > > > + return -ENODEV; > > + } > > + > > + if (enable && !device_may_wakeup(dev)) > > + return -EINVAL; > > + > > + clk_np = of_parse_phandle(dev->of_node, "fsl,pmc-handle", 0); > > + if (!clk_np) > > + return -EINVAL; > > + > > + prop = of_get_property(clk_np, "fsl,pmcdr-mask", NULL); > > + if (!prop) { > > + ret = -EINVAL; > > + goto out; > > + } > > + pmcdr_mask = be32_to_cpup(prop); > > + > > + if (enable) > > + /* clear to enable clock in low power mode */ > > + clrbits32(&pmc_regs->pmcdr, pmcdr_mask); > > + else > > + setbits32(&pmc_regs->pmcdr, pmcdr_mask); > > + > > +out: > > + of_node_put(clk_np); > > + return ret; > > +} > > +EXPORT_SYMBOL_GPL(mpc85xx_pmc_set_wake); > > Use EXPORT_SYMBOL, not EXPORT_SYMBOL_GPL. > > > + > > +/** > > + * mpc85xx_pmc_set_lossless_ethernet - enable lossless ethernet > > + * in (deep) sleep mode > > + * @enable: True to enable event generation; false to disable > > + */ > > +void mpc85xx_pmc_set_lossless_ethernet(int enable) > > Should this be 'bool enable'? > > > @@ -21,6 +22,17 @@ struct device_node; > > > > extern void fsl_rstcr_restart(char *cmd); > > > > +#ifdef CONFIG_FSL_PMC > > +extern int mpc85xx_pmc_set_wake(struct device *dev, bool enable); > > +extern void mpc85xx_pmc_set_lossless_ethernet(int enable); > > Don't use 'extern' for functions. > Why? I think there is no difference. -Chenhui -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/