Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756031Ab2HNKaG (ORCPT ); Tue, 14 Aug 2012 06:30:06 -0400 Received: from smtp.ispras.ru ([83.149.198.202]:54163 "EHLO smtp.ispras.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755928Ab2HNK3P (ORCPT ); Tue, 14 Aug 2012 06:29:15 -0400 From: Ilya Shchepetkov To: "K. Y. Srinivasan" Cc: Ilya Shchepetkov , Haiyang Zhang , "David S. Miller" , devel@linuxdriverproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@ispras.ru Subject: [PATCH 5/5] net/hyperv: Call netif_carrier_off() after register_netdev() Date: Tue, 14 Aug 2012 14:28:55 +0400 Message-Id: <1344940135-17079-6-git-send-email-shchepetkov@ispras.ru> X-Mailer: git-send-email 1.7.7 In-Reply-To: <1344940135-17079-1-git-send-email-shchepetkov@ispras.ru> References: <1344940135-17079-1-git-send-email-shchepetkov@ispras.ru> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1568 Lines: 47 For carrier detection to work properly when binding the driver with a cable unplugged, netif_carrier_off() should be called after register_netdev(), not before. Calling netif_carrier_off() before register_netdev() was causing the network interface to miss a linkwatch pending event leading to an inconsistent state if the link is not up when interface is initialized. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Ilya Shchepetkov --- drivers/net/hyperv/netvsc_drv.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index 8c5a1c4..5734ad0 100644 --- a/drivers/net/hyperv/netvsc_drv.c +++ b/drivers/net/hyperv/netvsc_drv.c @@ -416,9 +416,6 @@ static int netvsc_probe(struct hv_device *dev, if (!net) return -ENOMEM; - /* Set initial state */ - netif_carrier_off(net); - net_device_ctx = netdev_priv(net); net_device_ctx->device_ctx = dev; hv_set_drvdata(dev, net); @@ -441,6 +438,9 @@ static int netvsc_probe(struct hv_device *dev, goto out; } + /* Set initial state */ + netif_carrier_off(net); + /* Notify the netvsc driver of the new device */ device_info.ring_size = ring_size; ret = rndis_filter_device_add(dev, &device_info); -- 1.7.7 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/