Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755063Ab2HNMgP (ORCPT ); Tue, 14 Aug 2012 08:36:15 -0400 Received: from cmexedge1.ext.emulex.com ([138.239.224.99]:24954 "EHLO CMEXEDGE1.ext.emulex.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753925Ab2HNMgN convert rfc822-to-8bit (ORCPT ); Tue, 14 Aug 2012 08:36:13 -0400 From: To: , CC: , , , , , , Subject: RE: [PATCH 3/5] net/mlx4_en: Call netif_carrier_off() after register_netdev() Thread-Topic: [PATCH 3/5] net/mlx4_en: Call netif_carrier_off() after register_netdev() Thread-Index: AQHNegfYrwaJEAtF5EmS57T9A8F4rpdZO+pA Date: Tue, 14 Aug 2012 12:36:12 +0000 Message-ID: References: <1344940135-17079-1-git-send-email-shchepetkov@ispras.ru> <1344940135-17079-4-git-send-email-shchepetkov@ispras.ru> In-Reply-To: <1344940135-17079-4-git-send-email-shchepetkov@ispras.ru> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [138.239.142.128] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 995 Lines: 21 >-----Original Message----- >From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] On >Behalf Of Ilya Shchepetkov > >For carrier detection to work properly when binding the driver with a >cable unplugged, netif_carrier_off() should be called after >register_netdev(), not before. > >Calling netif_carrier_off() before register_netdev() was causing the >network interface to miss a linkwatch pending event leading to an >inconsistent state if the link is not up when interface is initialized. ndo_open() may be called as soon register_netdev() completes... When netif_carrier_off() is called *after* register_netdev(), isn't there a possibility of a ndo_open()->netif_carrier_on() call racing this call, causing incorrect results? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/