Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753817Ab2HNV1Z (ORCPT ); Tue, 14 Aug 2012 17:27:25 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:48230 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752630Ab2HNV1X (ORCPT ); Tue, 14 Aug 2012 17:27:23 -0400 Date: Tue, 14 Aug 2012 22:27:21 +0100 From: Al Viro To: Cyrill Gorcunov Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Alexey Dobriyan , Andrew Morton , Pavel Emelyanov , James Bottomley , Matthew Helsley Subject: Re: [patch 3/8] procfs: Add ability to plug in auxiliary fdinfo providers Message-ID: <20120814212721.GJ23464@ZenIV.linux.org.uk> References: <20120814140342.354405844@openvz.org> <20120814140620.033884909@openvz.org> <20120814183142.GH23464@ZenIV.linux.org.uk> <20120814183558.GA1551@moon> <20120814195649.GB31043@moon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120814195649.GB31043@moon> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 764 Lines: 18 On Tue, Aug 14, 2012 at 11:56:49PM +0400, Cyrill Gorcunov wrote: > Al, does the patch below looks better? If so I'll fix up the rest. > struct file_operations { > struct module *owner; > + struct seq_operations *fdinfo_ops; IDGI. Why on the earth do you need the whole iterator? All it takes is show_fdinfo(struct seq_file *m, struct file *f); have ->show() in your iterator (one going through the files) call that sucker for the file we are trying to show. I think you are severely overdesigning that thing... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/