Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752392Ab2HNWVx (ORCPT ); Tue, 14 Aug 2012 18:21:53 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:46594 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751095Ab2HNWVv (ORCPT ); Tue, 14 Aug 2012 18:21:51 -0400 Date: Wed, 15 Aug 2012 02:21:47 +0400 From: Cyrill Gorcunov To: Al Viro Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Alexey Dobriyan , Andrew Morton , Pavel Emelyanov , James Bottomley , Matthew Helsley Subject: Re: [patch 3/8] procfs: Add ability to plug in auxiliary fdinfo providers Message-ID: <20120814222147.GA21674@moon> References: <20120814140342.354405844@openvz.org> <20120814140620.033884909@openvz.org> <20120814183142.GH23464@ZenIV.linux.org.uk> <20120814183558.GA1551@moon> <20120814195649.GB31043@moon> <20120814212721.GJ23464@ZenIV.linux.org.uk> <20120814215616.GC31043@moon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120814215616.GC31043@moon> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1304 Lines: 27 On Wed, Aug 15, 2012 at 01:56:16AM +0400, Cyrill Gorcunov wrote: > > > struct file_operations { > > > struct module *owner; > > > + struct seq_operations *fdinfo_ops; > > > > IDGI. Why on the earth do you need the whole iterator? All it takes > > is show_fdinfo(struct seq_file *m, struct file *f); have ->show() in > > your iterator (one going through the files) call that sucker for the > > file we are trying to show. > > > > I think you are severely overdesigning that thing... > > Hmm, in very first versions I've been using one ->show method, but > then I thought that this is not very correlate with seq-files idea > where for each record show/next sequence is called. I'll update (this > for sure will make code simplier, and I'll have to check for seq-file > overflow after seq_printf call to not continue printing data for too > long if buffer already out of space). Al, I'll cook the whole series tomorrow and resend it for review, also I guess the new show_fdinfo() member in file-operations should be guarded with CONFIG_PROC_FS, right? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/