Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754280Ab2HNXXX (ORCPT ); Tue, 14 Aug 2012 19:23:23 -0400 Received: from filtteri2.pp.htv.fi ([213.243.153.185]:55825 "EHLO filtteri2.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753151Ab2HNXXV (ORCPT ); Tue, 14 Aug 2012 19:23:21 -0400 Date: Wed, 15 Aug 2012 02:22:50 +0300 From: Aaro Koskinen To: Catalin Marinas Cc: linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Marc Zyngier , Will Deacon , linux-kernel@vger.kernel.org, Arnd Bergmann Subject: Re: [PATCH v2 11/31] arm64: IRQ handling Message-ID: <20120814232250.GB747@harshnoise.musicnaut.iki.fi> References: <1344966752-16102-1-git-send-email-catalin.marinas@arm.com> <1344966752-16102-12-git-send-email-catalin.marinas@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1344966752-16102-12-git-send-email-catalin.marinas@arm.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 816 Lines: 27 Hi, On Tue, Aug 14, 2012 at 06:52:12PM +0100, Catalin Marinas wrote: > +void handle_IRQ(unsigned int irq, struct pt_regs *regs) > +{ > + struct pt_regs *old_regs = set_irq_regs(regs); > + > + irq_enter(); > + > + /* > + * Some hardware gives randomly wrong interrupts. Rather > + * than crashing, do something sensible. > + */ > + if (unlikely(irq >= nr_irqs)) { > + if (printk_ratelimit()) > + pr_warning("Bad IRQ%u\n", irq); I guess pr_warn_ratelimited() should be used for new code. (See include/linux/printk.h, "Please don't use printk_ratelimit()...") A. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/