Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754296Ab2HOOhS (ORCPT ); Wed, 15 Aug 2012 10:37:18 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:49952 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750833Ab2HOOhQ (ORCPT ); Wed, 15 Aug 2012 10:37:16 -0400 Date: Wed, 15 Aug 2012 10:37:15 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Julia Lawall cc: kernel-janitors@vger.kernel.org, Greg Kroah-Hartman , , Subject: Re: [PATCH 5/5] drivers/usb/host/ehci-platform.c: fix error return code In-Reply-To: <1344926858-1162-6-git-send-email-Julia.Lawall@lip6.fr> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1037 Lines: 33 On Tue, 14 Aug 2012, Julia Lawall wrote: > From: Julia Lawall > > Convert a possibly 0 error return code to a negative one, as returned > elsewhere in the function. ... > diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platform.c > index 91acdde..764e010 100644 > --- a/drivers/usb/host/ehci-platform.c > +++ b/drivers/usb/host/ehci-platform.c > @@ -128,8 +128,10 @@ static int __devinit ehci_platform_probe(struct platform_device *dev) > } > > hcd->regs = ioremap_nocache(hcd->rsrc_start, hcd->rsrc_len); > - if (!hcd->regs) > + if (!hcd->regs) { > + err = -ENOMEM; > goto err_release_region; > + } > err = usb_add_hcd(hcd, irq, IRQF_SHARED); > if (err) > goto err_iounmap; Acked-by: Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/