Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755402Ab2HORRS (ORCPT ); Wed, 15 Aug 2012 13:17:18 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:45378 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753597Ab2HORRQ (ORCPT ); Wed, 15 Aug 2012 13:17:16 -0400 MIME-Version: 1.0 Reply-To: sedat.dilek@gmail.com In-Reply-To: <1345045700-9062-12-git-send-email-miklos@szeredi.hu> References: <1345045700-9062-1-git-send-email-miklos@szeredi.hu> <1345045700-9062-12-git-send-email-miklos@szeredi.hu> Date: Wed, 15 Aug 2012 19:17:14 +0200 Message-ID: Subject: Re: [PATCH 11/13] vfs: export __inode_permission() to modules From: Sedat Dilek To: Miklos Szeredi Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, hch@infradead.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, apw@canonical.com, nbd@openwrt.org, neilb@suse.de, hramrach@centrum.cz, jordipujolp@gmail.com, ezk@fsl.cs.sunysb.edu, ricwheeler@gmail.com, dhowells@redhat.com, hpj@urpla.net, sedat.dilek@googlemail.com, penberg@kernel.org, goran.cetusic@gmail.com, romain@orebokech.com, mszeredi@suse.cz Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2490 Lines: 75 On Wed, Aug 15, 2012 at 5:48 PM, Miklos Szeredi wrote: > From: Miklos Szeredi > > We need to be able to check inode permissions (but not filesystem implied > permissions) for stackable filesystems. Expose this interface for overlayfs. > This patch can go through Al's vfs tree? It's an addendum for the below patch "VFS: Split inode_permission()" [1] from the first pile of vfs patches for v3.6-rc1 (first bits of/for union-mounts!). I talked with Andy on #ubuntu-kernel that the export is needed when OverlayFS is built as a module. Comments? - Sedat - [1] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commitdiff;h=0bdaea9017b9d2b9996e153a71ee03555969b80e > Signed-off-by: Miklos Szeredi > --- > fs/internal.h | 5 ----- > fs/namei.c | 1 + > include/linux/fs.h | 1 + > 3 files changed, 2 insertions(+), 5 deletions(-) > > diff --git a/fs/internal.h b/fs/internal.h > index 371bcc4..8578209 100644 > --- a/fs/internal.h > +++ b/fs/internal.h > @@ -42,11 +42,6 @@ static inline int __sync_blockdev(struct block_device *bdev, int wait) > extern void __init chrdev_init(void); > > /* > - * namei.c > - */ > -extern int __inode_permission(struct inode *, int); > - > -/* > * namespace.c > */ > extern int copy_mount_options(const void __user *, unsigned long *); > diff --git a/fs/namei.c b/fs/namei.c > index ac2526d..9be439a 100644 > --- a/fs/namei.c > +++ b/fs/namei.c > @@ -348,6 +348,7 @@ int __inode_permission(struct inode *inode, int mask) > > return security_inode_permission(inode, mask); > } > +EXPORT_SYMBOL(__inode_permission); > > /** > * sb_permission - Check superblock-level permissions > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 1265e24..d573703 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -2418,6 +2418,7 @@ extern sector_t bmap(struct inode *, sector_t); > #endif > extern int notify_change(struct dentry *, struct iattr *); > extern int inode_permission(struct inode *, int); > +extern int __inode_permission(struct inode *, int); > extern int generic_permission(struct inode *, int); > > static inline bool execute_ok(struct inode *inode) > -- > 1.7.7 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/