Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757247Ab2HPBgH (ORCPT ); Wed, 15 Aug 2012 21:36:07 -0400 Received: from mail-wg0-f44.google.com ([74.125.82.44]:65388 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756360Ab2HPBgB (ORCPT ); Wed, 15 Aug 2012 21:36:01 -0400 MIME-Version: 1.0 In-Reply-To: <1344946071.3117.26.camel@dabdike.int.hansenpartnership.com> References: <1344946071.3117.26.camel@dabdike.int.hansenpartnership.com> Date: Thu, 16 Aug 2012 10:35:59 +0900 Message-ID: Subject: Re: [PATCH RESEND] remove the queue unlock in scsi_requset_fn From: Chanho Min To: James Bottomley Cc: Mike Christie , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Jens Axboe , Tejun Heo , Bart Van Assche Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 652 Lines: 14 > functions will occur in line. I also don't see why the sdev reference > couldn't drop to zero here. scsi_request_fn is called under the lock of request_queue->queue_lock. If we drop the sdev reference to zero here, scsi_device_dev_release_usercontext is invoked and make request_queue to NULL. When caller of scsi_request_fn try to unlock request_queue->queue_lock, the oops is occurred. Thanks, Chanho -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/