Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753944Ab2HPFsn (ORCPT ); Thu, 16 Aug 2012 01:48:43 -0400 Received: from hqemgate03.nvidia.com ([216.228.121.140]:18528 "EHLO hqemgate03.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751325Ab2HPFsl convert rfc822-to-8bit (ORCPT ); Thu, 16 Aug 2012 01:48:41 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Wed, 15 Aug 2012 22:43:06 -0700 From: Venu Byravarasu To: Andrew Morton CC: "a.zummo@towertech.it" , "sameo@linux.intel.com" , "broonie@opensource.wolfsonmicro.com" , Laxman Dewangan , "kyle.manna@fuel7.com" , "rtc-linux@googlegroups.com" , "linux-kernel@vger.kernel.org" Date: Thu, 16 Aug 2012 11:18:34 +0530 Subject: RE: [PATCH] rtc: tps65910: Add RTC driver for TPS65910 PMIC RTC Thread-Topic: [PATCH] rtc: tps65910: Add RTC driver for TPS65910 PMIC RTC Thread-Index: Ac16d9XuenBB1iUfRmOwI8PofhMlzQA+m6cQ Message-ID: References: <1343284519-30505-1-git-send-email-vbyravarasu@nvidia.com> <20120814165211.daf24c81.akpm@linux-foundation.org> In-Reply-To: <20120814165211.daf24c81.akpm@linux-foundation.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2448 Lines: 73 Hi Andrew, Already an updated patch v3 (http://lkml.org/lkml/2012/8/8/221 ) was pushed to fix these issues. Plz review and merged that. Thanks, Venu > -----Original Message----- > From: Andrew Morton [mailto:akpm@linux-foundation.org] > Sent: Wednesday, August 15, 2012 5:22 AM > To: Venu Byravarasu > Cc: a.zummo@towertech.it; sameo@linux.intel.com; > broonie@opensource.wolfsonmicro.com; Laxman Dewangan; > kyle.manna@fuel7.com; rtc-linux@googlegroups.com; linux- > kernel@vger.kernel.org > Subject: Re: [PATCH] rtc: tps65910: Add RTC driver for TPS65910 PMIC RTC > > On Thu, 26 Jul 2012 12:05:19 +0530 > Venu Byravarasu wrote: > > > TPS65910 PMIC is a MFD with RTC as one of the device. > > Adding RTC driver for supporting RTC device present > > inside TPS65910 PMIC. > > > > Only support for RTC alarm is implemented as part of this patch. > > It needs a build fix: > > drivers/rtc/rtc-tps65910.c: In function 'tps65910_rtc_suspend': > drivers/rtc/rtc-tps65910.c:313: error: request for member 'irqstat' in > something not a structure or union > drivers/rtc/rtc-tps65910.c: In function 'tps65910_rtc_resume': > drivers/rtc/rtc-tps65910.c:327: error: request for member 'irqstat' in > something not a structure or union > > --- a/drivers/rtc/rtc-tps65910.c~rtc-tps65910-add-rtc-driver-for-tps65910- > pmic-rtc-fix > +++ a/drivers/rtc/rtc-tps65910.c > @@ -310,7 +310,7 @@ static int tps65910_rtc_suspend(struct p > > /* Store current list of enabled interrupts*/ > ret = regmap_read(tps->regmap, TPS65910_RTC_INTERRUPTS, > - &tps->rtc.irqstat); > + &tps->rtc->irqstat); > if (ret < 0) > return ret; > > @@ -324,7 +324,7 @@ static int tps65910_rtc_resume(struct pl > > /* Restore list of enabled interrupts before suspend */ > return regmap_write(tps->regmap, TPS65910_RTC_INTERRUPTS, > - tps->rtc.irqstat); > + tps->rtc->irqstat); > } > > static const struct dev_pm_ops tps65910_rtc_pm_ops = { > > > but it still has problems: > > drivers/rtc/rtc-tps65910.c:331: warning: initialization from incompatible > pointer type > drivers/rtc/rtc-tps65910.c:332: warning: initialization from incompatible > pointer type > > fix and resend, please? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/