Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932562Ab2HPNy4 (ORCPT ); Thu, 16 Aug 2012 09:54:56 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:42289 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932328Ab2HPNyv (ORCPT ); Thu, 16 Aug 2012 09:54:51 -0400 Date: Thu, 16 Aug 2012 17:54:48 +0400 From: Cyrill Gorcunov To: Al Viro Cc: Pavel Emelyanov , "J. Bruce Fields" , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , Alexey Dobriyan , Andrew Morton , James Bottomley , Matthew Helsley Subject: Re: [patch 4/8] fs, exportfs: Add export_encode_inode_fh helper Message-ID: <20120816135448.GP32081@moon> References: <20120815092116.700948346@openvz.org> <20120815092409.591460800@openvz.org> <20120815204546.GC25062@fieldses.org> <20120815210237.GF25421@moon> <20120815220622.GA28054@fieldses.org> <20120816062448.GA32081@moon> <20120816123814.GD1209@moon> <20120816134339.GQ23464@ZenIV.linux.org.uk> <502CF9DA.8030701@parallels.com> <20120816135019.GS23464@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120816135019.GS23464@ZenIV.linux.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1409 Lines: 30 On Thu, Aug 16, 2012 at 02:50:19PM +0100, Al Viro wrote: > On Thu, Aug 16, 2012 at 05:47:06PM +0400, Pavel Emelyanov wrote: > > On 08/16/2012 05:43 PM, Al Viro wrote: > > > On Thu, Aug 16, 2012 at 04:38:14PM +0400, Cyrill Gorcunov wrote: > > > > > >> Hi Bruce, thinking a bit more I guess using general encode_fh is not that > > >> convenient since it operates with dentries while our fdinfo output deals > > >> with inodes. Thus I should either provide some new encode_fh variant > > >> which would deal with inodes directly without "parents". Which doesn't > > >> look for me anyhow better than the new export_encode_inode_fh helper. > > > > > > Huh? You do have dentries, for crying out loud... > > > > Sometimes we don't -- the inotify thing gets an inode only. > > Unlike other notifies that have dentries at hands... > > What's wrong with saying "we don't support idiotify"? Al, we need some way to restore inotifies after checkpoint. At the very early versions of these patches I simply added dentry to the inotify mark thus once inotify created we always have a dentry to refer on in encode_fh, but I'm not sure if this will be good design. Cyrill -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/