Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932798Ab2HPPgH (ORCPT ); Thu, 16 Aug 2012 11:36:07 -0400 Received: from mail-lpp01m010-f46.google.com ([209.85.215.46]:33138 "EHLO mail-lpp01m010-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932735Ab2HPPgE (ORCPT ); Thu, 16 Aug 2012 11:36:04 -0400 Date: Thu, 16 Aug 2012 19:35:59 +0400 From: Cyrill Gorcunov To: Pavel Emelyanov Cc: Al Viro , "J. Bruce Fields" , James Bottomley , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , Alexey Dobriyan , Andrew Morton , Matthew Helsley Subject: Re: [patch 4/8] fs, exportfs: Add export_encode_inode_fh helper Message-ID: <20120816153559.GD13382@moon> References: <20120816134339.GQ23464@ZenIV.linux.org.uk> <502CF9DA.8030701@parallels.com> <20120816135019.GS23464@ZenIV.linux.org.uk> <20120816135448.GP32081@moon> <1345125779.3259.50.camel@dabdike.int.hansenpartnership.com> <20120816141553.GF1209@moon> <20120816144152.GT23464@ZenIV.linux.org.uk> <20120816144835.GC13066@moon> <20120816145527.GU23464@ZenIV.linux.org.uk> <502D0C6A.3010908@parallels.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <502D0C6A.3010908@parallels.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1696 Lines: 37 On Thu, Aug 16, 2012 at 07:06:18PM +0400, Pavel Emelyanov wrote: > On 08/16/2012 06:55 PM, Al Viro wrote: > > On Thu, Aug 16, 2012 at 06:48:35PM +0400, Cyrill Gorcunov wrote: > > > >>> Good luck doing that with e.g. VFAT... And then there's such thing > >>> as filesystems that don't have ->encode_fh() for a lot of very good > >> > >> Wait, Al, it seems I messed up. If some fs has no encode_fh() implemented > >> the default encoding with FILEID_INO32_GEN_PARENT will be used for that. > > > > ... which doesn't work for a lot of filesystems. Not if you want to be > > able to decode the result afterwards and get something useful out of > > that. Trying to implement ->fh_to_dentry(), especially with fhandle > > generated by inode alone is going to be really interesting for a bunch > > of stuff... > > . > > > > Hm... Then I suppose the best we can do is -- show in a fdinfo file the inode > number, device where it is and a filehandle _iff_ provided by a filesystem. > For fanotify/dnotify -- only a path. For notifications on mount points it's not a problem (we already do that + ret = seq_printf(m, "fanotify mnt_id: %8x mask: %8x ignored_mask: %8x\n", + mnt->mnt_id, mark->mask, mark->ignored_mask); printing inode number and device it's easy as well. Fetching the path is not obvious for me since inotify carries inodes only. To generate path I would have to obtain dentry from inode I suppose, that's what you mean? Cyrill -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/