Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030243Ab2HPQPy (ORCPT ); Thu, 16 Aug 2012 12:15:54 -0400 Received: from mail-wg0-f44.google.com ([74.125.82.44]:62249 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964789Ab2HPQPt (ORCPT ); Thu, 16 Aug 2012 12:15:49 -0400 Message-ID: <502D1B32.7020005@gmail.com> Date: Thu, 16 Aug 2012 18:09:22 +0200 From: Marco Stornelli User-Agent: Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120601 Thunderbird/13.0 MIME-Version: 1.0 To: Boaz Harrosh CC: dedekind1@gmail.com, bhalevy@tonian.com, jack@suse.cz, Andrew Morton , adilger.kernel@dilger.ca, tytso@mit.edu, hirofumi@mail.parknet.co.jp, mikulas@artax.karlin.mff.cuni.cz, Al Viro , hch@infradead.org, dushistov@mail.ru, osd-dev@open-osd.org, Linux Kernel , linux-ext4@vger.kernel.org, Linux FS Devel Subject: Re: [PATCH 2/8] exofs: remove lock/unlock super References: <502CC4AA.6040702@gmail.com> <1345119652.3393.220.camel@sauron.fi.intel.com> <502CE840.4060802@panasas.com> In-Reply-To: <502CE840.4060802@panasas.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1091 Lines: 36 Il 16/08/2012 14:32, Boaz Harrosh ha scritto: > On 08/16/2012 03:20 PM, Artem Bityutskiy wrote: > >> On Thu, 2012-08-16 at 12:00 +0200, Marco Stornelli wrote: >>> From: Marco Stornelli >>> >>> Remove lock and unlock super operation. >>> >>> Signed-off-by: Marco Stornelli >> >> Acked-by: Artem Bityutskiy >> > > > Are you sure? It used to be that exofs_sync_fs() could be called > concurrently. > > What about two "bash -c sync" calls or a sync and an unmount > in parallel. anything protecting that? > > If so then sure, but please let me test first. > Boaz > > . > Yes Boaz, I agree, it's the reason I asked for a comments for exofs and hpfs. The only reason to have a lock here is to serialize operations in parallel on the same super block. Marco -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/