Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932439Ab2HPTNG (ORCPT ); Thu, 16 Aug 2012 15:13:06 -0400 Received: from mail-qa0-f53.google.com ([209.85.216.53]:33076 "EHLO mail-qa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756368Ab2HPTNC (ORCPT ); Thu, 16 Aug 2012 15:13:02 -0400 MIME-Version: 1.0 In-Reply-To: <1345144127.3402.2.camel@falcor.watson.ibm.com> References: <1345144127.3402.2.camel@falcor.watson.ibm.com> Date: Thu, 16 Aug 2012 15:13:01 -0400 Message-ID: Subject: Re: [RFC v2 2/7] keys: initialize root uid and session keyrings early From: Josh Boyer To: Mimi Zohar Cc: Dmitry Kasatkin , jmorris@namei.org, rusty@rustcorp.com.au, dhowells@redhat.com, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Mimi Zohar Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 901 Lines: 27 On Thu, Aug 16, 2012 at 3:08 PM, Mimi Zohar wrote: >> > +#include "internal.h" >> > +static int __init init_root_keyring(void) >> > +{ >> > + return install_user_keyrings(); >> > +} >> > + >> > +late_initcall(init_root_keyring); >> > -- >> >> Why is this in an entirely new file instead of just being added to >> process_keys.c ? >> >> josh > > Only when "CONFIG_INTEGRITY_SIGNATURE" is selected, does this get built. Yes, I noticed that. It doesn't explain why it's in its own file. You could accomplish the same thing by wrapping the function and initcall in #ifdef CONFIG_INTEGRITY_SIGNATURE in process_keys.c. josh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/