Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933227Ab2HPTrq (ORCPT ); Thu, 16 Aug 2012 15:47:46 -0400 Received: from e31.co.us.ibm.com ([32.97.110.149]:33988 "EHLO e31.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933208Ab2HPTrn (ORCPT ); Thu, 16 Aug 2012 15:47:43 -0400 Message-ID: <1345146349.3402.21.camel@falcor.watson.ibm.com> Subject: Re: [RFC v2 2/7] keys: initialize root uid and session keyrings early From: Mimi Zohar To: Josh Boyer Cc: Dmitry Kasatkin , jmorris@namei.org, rusty@rustcorp.com.au, dhowells@redhat.com, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Mimi Zohar Date: Thu, 16 Aug 2012 15:45:49 -0400 In-Reply-To: References: <1345144127.3402.2.camel@falcor.watson.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3 (3.2.3-3.fc16) Content-Transfer-Encoding: 7bit Mime-Version: 1.0 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12081619-7282-0000-0000-00000C094152 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1143 Lines: 33 On Thu, 2012-08-16 at 15:13 -0400, Josh Boyer wrote: > On Thu, Aug 16, 2012 at 3:08 PM, Mimi Zohar wrote: > >> > +#include "internal.h" > >> > +static int __init init_root_keyring(void) > >> > +{ > >> > + return install_user_keyrings(); > >> > +} > >> > + > >> > +late_initcall(init_root_keyring); > >> > -- > >> > >> Why is this in an entirely new file instead of just being added to > >> process_keys.c ? > >> > >> josh > > > > Only when "CONFIG_INTEGRITY_SIGNATURE" is selected, does this get built. > > Yes, I noticed that. It doesn't explain why it's in its own file. You > could accomplish the same thing by wrapping the function and initcall > in #ifdef CONFIG_INTEGRITY_SIGNATURE in process_keys.c. I was under the impression using 'ifdefs' in 'C' code was frowned upon (Documentation/SubmittingPatches section 2.2). This would be an exception? Mimi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/