Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757595Ab2HQBe6 (ORCPT ); Thu, 16 Aug 2012 21:34:58 -0400 Received: from mail-qa0-f46.google.com ([209.85.216.46]:57744 "EHLO mail-qa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754734Ab2HQBe4 convert rfc822-to-8bit (ORCPT ); Thu, 16 Aug 2012 21:34:56 -0400 MIME-Version: 1.0 In-Reply-To: <502D9938.2010908@windriver.com> References: <20120816073724.GA10660@localhost> <502CBF23.4070805@windriver.com> <20120816151949.GA18681@localhost> <502D9938.2010908@windriver.com> From: Paul Gortmaker Date: Thu, 16 Aug 2012 21:34:25 -0400 X-Google-Sender-Auth: f4eqttr727ioVCAUPM9e8AWXbQM Message-ID: Subject: Re: suspicious RCU usage in xfrm_net_init() To: Fan Du Cc: David Miller , Fengguang Wu , Priyanka Jain , netdev@vger.kernel.org, LKML Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5781 Lines: 174 On Thu, Aug 16, 2012 at 9:07 PM, Fan Du wrote: > > > On 2012年08月16日 23:19, Fengguang Wu wrote: >> >> Hi Fan, >> >> On Thu, Aug 16, 2012 at 05:36:35PM +0800, Fan Du wrote: >>> >>> >>> Hi, Fengguang >>> >>> Could you please try the below patch, see if spewing still there? >>> thanks >> >> >> Yes, it worked, thank you very much! >> > > Hi, Dave > > Could you please pick up this patch? Please do not make extra work for maintainers by sending attachments, or requests for status/merge etc. Your 1st patch had to be manually set to an RFC, and now you add another patch less than 24h later. Please see: http://patchwork.ozlabs.org/patch/177934/ http://patchwork.ozlabs.org/patch/178132/ Also, a patch should describe the problem it solves (i.e. the symptom the end user sees), and how the problem originated, and why the fix in the patch is the _right_ fix. The worst description a commit log can have is one that just describes the C change in words, since most people can read C on their own. Here you add "_bh" in the code and then repeat exactly that in the commit log. Your commit log does not tell me when it broke, or why it broke, or who had their use case broken. Can you see why this is not acceptable? Please take the time to look at the traffic in netdev, and read the feedback given by maintainers on other patches, so that the common errors are understood by you, and not repeated. It will be time well spent! Thanks, Paul. --- > thanks > > > > >> btw, your email client wraps long lines.. >> > Oh, I will definitely fix this. > thanks feng guang for the testing :) > > > >> Thanks, >> Fengguang >> >>> From a3f86ecc3ee16ff81d49416bbf791780422988b3 Mon Sep 17 00:00:00 2001 >>> From: Fan Du >>> Date: Thu, 16 Aug 2012 17:31:25 +0800 >>> Subject: [PATCH] Use rcu_dereference_bh to deference pointer >>> protected by rcu_read_lock_bh >>> >>> Signed-off-by: Fan Du >>> --- >>> net/xfrm/xfrm_policy.c | 2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c >>> index 5ad4d2c..75a9d6a 100644 >>> --- a/net/xfrm/xfrm_policy.c >>> +++ b/net/xfrm/xfrm_policy.c >>> @@ -2501,7 +2501,7 @@ static void __net_init >>> xfrm_dst_ops_init(struct net *net) >>> struct xfrm_policy_afinfo *afinfo; >>> >>> rcu_read_lock_bh(); >>> - afinfo = rcu_dereference(xfrm_policy_afinfo[AF_INET]); >>> + afinfo = rcu_dereference_bh(xfrm_policy_afinfo[AF_INET]); >>> if (afinfo) >>> net->xfrm.xfrm4_dst_ops = *afinfo->dst_ops; >>> #if IS_ENABLED(CONFIG_IPV6) >>> -- >>> 1.7.1 >>> >>> >>> >>> >>> On 2012年08月16日 15:37, Fengguang Wu wrote: >>>> >>>> Hi Priyanka, >>>> >>>> The below warning shows up, probably related to this commit: >>>> >>>> 418a99ac6ad487dc9c42e6b0e85f941af56330f2 Replace rwlock on >>>> xfrm_policy_afinfo with rcu >>>> >>>> [ 0.921216] >>>> [ 0.921645] =============================== >>>> [ 0.922766] [ INFO: suspicious RCU usage. ] >>>> [ 0.923887] 3.5.0-01540-g1669891 #64 Not tainted >>>> [ 0.925123] ------------------------------- >>>> [ 0.932860] /c/kernel-tests/src/tip/net/xfrm/xfrm_policy.c:2504 >>>> suspicious rcu_dereference_check() usage! >>>> [ 0.935361] >>>> [ 0.935361] other info that might help us debug this: >>>> [ 0.935361] >>>> [ 0.937472] >>>> [ 0.937472] rcu_scheduler_active = 1, debug_locks = 0 >>>> [ 0.939182] 2 locks held by swapper/1: >>>> [ 0.940171] #0: (net_mutex){+.+.+.}, at: [] >>>> register_pernet_subsys+0x21/0x57 >>>> [ 0.942705] #1: (rcu_read_lock_bh){......}, at: >>>> [] xfrm_net_init+0x1e4/0x437 >>>> [ 0.951507] >>>> [ 0.951507] stack backtrace: >>>> [ 0.952660] Pid: 1, comm: swapper Not tainted 3.5.0-01540-g1669891 >>>> #64 >>>> [ 0.954364] Call Trace: >>>> [ 0.955074] [] lockdep_rcu_suspicious+0x174/0x187 >>>> [ 0.956736] [] xfrm_net_init+0x30e/0x437 >>>> [ 0.958205] [] ? xfrm_net_init+0x1e4/0x437 >>>> [ 0.959712] [] ops_init+0x1bb/0x1ff >>>> [ 0.961067] [] ? trace_hardirqs_on+0x1b/0x24 >>>> [ 0.962644] [] >>>> register_pernet_operations.isra.5+0x9d/0xfe >>>> [ 0.971376] [] register_pernet_subsys+0x30/0x57 >>>> [ 0.972992] [] xfrm_init+0x17/0x2c >>>> [ 0.974316] [] ip_rt_init+0x82/0xe7 >>>> [ 0.975668] [] ip_init+0x10/0x25 >>>> [ 0.976952] [] inet_init+0x235/0x360 >>>> [ 0.978352] [] ? devinet_init+0xf2/0xf2 >>>> [ 0.979808] [] do_one_initcall+0xb4/0x203 >>>> [ 0.981313] [] kernel_init+0x1a9/0x29a >>>> [ 0.982732] [] ? loglevel+0x46/0x46 >>>> [ 0.990889] [] kernel_thread_helper+0x4/0x10 >>>> [ 0.992472] [] ? retint_restore_args+0x13/0x13 >>>> [ 0.994076] [] ? do_one_initcall+0x203/0x203 >>>> [ 0.995636] [] ? gs_change+0x13/0x13 >>>> [ 0.997197] TCP established hash table entries: 8192 (order: 5, >>>> 131072 bytes) >>>> [ 1.000074] TCP bind hash table entries: 8192 (order: 7, 655360 >>>> bytes) >>>> >>>> Thanks, >>>> Fengguang >>> >>> >>> -- >>> >>> Love each day! >>> --fan >> >> > > -- > > Love each day! > --fan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/