Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030645Ab2HQDz3 (ORCPT ); Thu, 16 Aug 2012 23:55:29 -0400 Received: from mail-lpp01m010-f46.google.com ([209.85.215.46]:43665 "EHLO mail-lpp01m010-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030599Ab2HQDz0 (ORCPT ); Thu, 16 Aug 2012 23:55:26 -0400 MIME-Version: 1.0 In-Reply-To: <1345117305-8299-6-git-send-email-amit.kachhap@linaro.org> References: <1345117305-8299-1-git-send-email-amit.kachhap@linaro.org> <1345117305-8299-6-git-send-email-amit.kachhap@linaro.org> Date: Fri, 17 Aug 2012 09:25:24 +0530 Message-ID: Subject: Re: [PATCH v6 5/6] ARM: exynos: add thermal sensor driver platform data support From: Thomas Abraham To: Amit Daniel Kachhap Cc: linux-pm@lists.linux-foundation.org, Andrew Morton , Zhang Rui , Len Brown , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, lm-sensors@lm-sensors.org, SangWook Ju , Durgadoss , Jean Delvare , jonghwa lee , Kyungmin Park , Kukjin Kim Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 6505 Lines: 183 On 16 August 2012 17:11, Amit Daniel Kachhap wrote: > Add necessary default platform data support needed for TMU driver. The > supplied dt/non-dt values are tested for origen exynos4210 and smdk exynos5250 > platforms and only compile tested for exynos4412. > > Signed-off-by: Amit Daniel Kachhap > Acked-by: Guenter Roeck > Cc: SangWook Ju > Cc: Durgadoss > Cc: Len Brown > Cc: Jean Delvare > Cc: jonghwa lee > Cc: Kyungmin Park > Cc: Kukjin Kim > Signed-off-by: Andrew Morton > Signed-off-by: Amit Daniel Kachhap > --- > drivers/thermal/exynos_thermal.c | 111 +++++++++++++++++++++++++++++++++++++- > 1 files changed, 110 insertions(+), 1 deletions(-) Reviewed-by: Thomas Abraham Few minor comments inline below. > > diff --git a/drivers/thermal/exynos_thermal.c b/drivers/thermal/exynos_thermal.c > index e79cdc9..03a99e4 100644 > --- a/drivers/thermal/exynos_thermal.c > +++ b/drivers/thermal/exynos_thermal.c > @@ -723,14 +723,121 @@ static irqreturn_t exynos_tmu_irq(int irq, void *id) > static struct thermal_sensor_conf exynos_sensor_conf = { > .name = "exynos-therm", > .read_temperature = (int (*)(void *))exynos_tmu_read, > +}; > + > +#if defined(CONFIG_CPU_EXYNOS4210) > +static struct exynos_tmu_platform_data const exynos4210_default_tmu_data = { > + .threshold = 80, > + .trigger_levels[0] = 5, > + .trigger_levels[1] = 20, > + .trigger_levels[2] = 30, > + .trigger_level0_en = 1, > + .trigger_level1_en = 1, > + .trigger_level2_en = 1, > + .trigger_level3_en = 0, > + .gain = 15, > + .reference_voltage = 7, > + .cal_type = TYPE_ONE_POINT_TRIMMING, > + .freq_tab[0] = { > + .freq_clip_max = 800 * 1000, > + .temp_level = 85, > + }, > + .freq_tab[1] = { > + .freq_clip_max = 200 * 1000, > + .temp_level = 100, > + }, > + .freq_tab_count = 2, > + .type = SOC_ARCH_EXYNOS4210, > +}; > +#define EXYNOS4210_TMU_DRV_DATA (&exynos4210_default_tmu_data) > +#else > +#define EXYNOS4210_TMU_DRV_DATA (NULL) > +#endif > + > +#if defined(CONFIG_SOC_EXYNOS5250) || defined(CONFIG_SOC_EXYNOS4412) > +static struct exynos_tmu_platform_data const exynos_default_tmu_data = { > + .trigger_levels[0] = 85, > + .trigger_levels[1] = 103, > + .trigger_levels[2] = 110, > + .trigger_level0_en = 1, > + .trigger_level1_en = 1, > + .trigger_level2_en = 1, > + .trigger_level3_en = 0, > + .gain = 8, > + .reference_voltage = 16, > + .noise_cancel_mode = 4, > + .cal_type = TYPE_ONE_POINT_TRIMMING, > + .efuse_value = 55, > + .freq_tab[0] = { > + .freq_clip_max = 800 * 1000, > + .temp_level = 85, > + }, > + .freq_tab[1] = { > + .freq_clip_max = 200 * 1000, > + .temp_level = 103, > + }, > + .freq_tab_count = 2, > + .type = SOC_ARCH_EXYNOS, > +}; > +#define EXYNOS_TMU_DRV_DATA (&exynos_default_tmu_data) > +#else > +#define EXYNOS_TMU_DRV_DATA (NULL) > +#endif > + > +#ifdef CONFIG_OF > +static const struct of_device_id exynos_tmu_match[] = { > + { > + .compatible = "samsung,exynos4210-tmu", > + .data = (void *)EXYNOS4210_TMU_DRV_DATA, > + }, > + { This can be }, { > + .compatible = "samsung,exynos5250-tmu", > + .data = (void *)EXYNOS_TMU_DRV_DATA, > + }, > + {}, > +}; > +MODULE_DEVICE_TABLE(of, exynos_tmu_match); > +#else > +#define exynos_tmu_match NULL > +#endif > + > +static struct platform_device_id exynos_tmu_driver_ids[] = { > + { > + .name = "exynos4210-tmu", > + .driver_data = (kernel_ulong_t)EXYNOS4210_TMU_DRV_DATA, > + }, > + { > + .name = "exynos5250-tmu", > + .driver_data = (kernel_ulong_t)EXYNOS_TMU_DRV_DATA, > + }, Since Exynos5250 platforms are dt based, the above entry could be left out. > + { }, > +}; > +MODULE_DEVICE_TABLE(platform, exynos4_tmu_driver_ids); > + > +static inline struct exynos_tmu_platform_data *exynos_get_driver_data( > + struct platform_device *pdev) > +{ > +#ifdef CONFIG_OF > + if (pdev->dev.of_node) { > + const struct of_device_id *match; > + match = of_match_node(exynos_tmu_match, pdev->dev.of_node); > + if (!match) > + return NULL; > + return (struct exynos_tmu_platform_data *) match->data; > + } > +#endif > + return (struct exynos_tmu_platform_data *) > + platform_get_device_id(pdev)->driver_data; > } > -; > static int __devinit exynos_tmu_probe(struct platform_device *pdev) > { > struct exynos_tmu_data *data; > struct exynos_tmu_platform_data *pdata = pdev->dev.platform_data; > int ret, i; > > + if (!pdata) > + pdata = exynos_get_driver_data(pdev); > + > if (!pdata) { > dev_err(&pdev->dev, "No platform init data supplied.\n"); > return -ENODEV; > @@ -899,9 +1006,11 @@ static struct platform_driver exynos_tmu_driver = { > .name = "exynos-tmu", > .owner = THIS_MODULE, > .pm = EXYNOS_TMU_PM, > + .of_match_table = exynos_tmu_match, > }, > .probe = exynos_tmu_probe, > .remove = __devexit_p(exynos_tmu_remove), > + .id_table = exynos_tmu_driver_ids, > }; > > module_platform_driver(exynos_tmu_driver); > -- > 1.7.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/