Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964896Ab2HQG5B (ORCPT ); Fri, 17 Aug 2012 02:57:01 -0400 Received: from e23smtp02.au.ibm.com ([202.81.31.144]:37510 "EHLO e23smtp02.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964805Ab2HQG47 (ORCPT ); Fri, 17 Aug 2012 02:56:59 -0400 Message-ID: <502DEB32.8000106@linux.vnet.ibm.com> Date: Fri, 17 Aug 2012 14:56:50 +0800 From: Michael Wang User-Agent: Mozilla/5.0 (X11; Linux i686; rv:14.0) Gecko/20120714 Thunderbird/14.0 MIME-Version: 1.0 To: Peter Zijlstra CC: LKML , Ingo Molnar , Mike Galbraith Subject: Re: [PATCH] sched: remove useless code in yield_to References: <4F13EFBE.1030002@linux.vnet.ibm.com> <1326707503.2442.219.camel@twins> <4F14DEAE.60702@linux.vnet.ibm.com> <4F14E54E.80904@linux.vnet.ibm.com> <1327506934.2614.87.camel@laptop> <20120126100429.GA3853@elte.hu> <4F21FC69.6040402@linux.vnet.ibm.com> <4F222B2B.6010602@gmail.com> <4F24E804.5090808@linux.vnet.ibm.com> <20120129163328.GC23408@elte.hu> <4F260BFE.2070503@linux.vnet.ibm.com> <4F260DAE.4000008@gmail.com> <4F262ED9.7040003@linux.vnet.ibm.com> <4FF2925A.9060005@linux.vnet.ibm.com> <1342102029.28010.3.camel@twins> In-Reply-To: <1342102029.28010.3.camel@twins> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit x-cbid: 12081706-5490-0000-0000-000001F881D2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1767 Lines: 58 On 07/12/2012 10:07 PM, Peter Zijlstra wrote: > On Tue, 2012-07-03 at 14:34 +0800, Michael Wang wrote: >> From: Michael Wang >> >> it's impossible to enter else branch if we have set skip_clock_update >> in task_yield_fair(), as yield_to_task_fair() will directly return >> true after invoke task_yield_fair(). > > It helps if you CC the guy who wrote the code.. I think you're right, > although getting that skip_clock_update crap wrong is annoying. > > Mike? Hi, Peter I think Mike also agreed to remove that piece of code, should we action now? Regards, Michael Wang > > >> Signed-off-by: Michael Wang >> --- >> kernel/sched/core.c | 7 ------- >> 1 files changed, 0 insertions(+), 7 deletions(-) >> >> diff --git a/kernel/sched/core.c b/kernel/sched/core.c >> index 9bb7d28..77c14aa 100644 >> --- a/kernel/sched/core.c >> +++ b/kernel/sched/core.c >> @@ -4737,13 +4737,6 @@ again: >> */ >> if (preempt && rq != p_rq) >> resched_task(p_rq->curr); >> - } else { >> - /* >> - * We might have set it in task_yield_fair(), but are >> - * not going to schedule(), so don't want to skip >> - * the next update. >> - */ >> - rq->skip_clock_update = 0; >> } >> >> out: > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/