MIME-Version: 1.0
In-Reply-To: <20120817095837.GM18957@n2100.arm.linux.org.uk>
References: <1345196843-23059-1-git-send-email-richard.genoud@gmail.com> <20120817095837.GM18957@n2100.arm.linux.org.uk>
From: Richard Genoud <richard.genoud@gmail.com>
Date: Fri, 17 Aug 2012 12:23:06 +0200
Message-ID: <CACQ1gAh3YcMBXp7BFoR68+rdDM1PEe4fenNG77s=SP05RditEA@mail.gmail.com>
Subject: Re: [PATCH] BUG: clk_find() misses some clocks
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1327
Lines: 35

2012/8/17 Russell King - ARM Linux <linux@arm.linux.org.uk>:
> Please read the comments on the function:
>
>  * Find the correct struct clk for the device and connection ID.
>  * We do slightly fuzzy matching here:
>  *  An entry with a NULL ID is assumed to be a wildcard.
>  *  If an entry has a device ID, it must match
>  *  If an entry has a connection ID, it must match
>  * Then we take the most specific entry - with the following
>  * order of precedence: dev+con > dev only > con only.
>
> On Fri, Aug 17, 2012 at 11:47:23AM +0200, Richard Genoud wrote:
>> if a clock is declared like that:
>> CLKDEV_CON_DEV_ID("pioA", "fffff400.gpio", &pioAB_clk)
>
> So you've declared it with a connection ID.  Therefore, as the comment
> above says, "it must match" what the driver is asking for.
>
> It's not a bug, this is done intentionally so that mismatches do not
> occur.
Ok, so I have to declare it like that :
CLKDEV_CON_DEV_ID(NULL, "fffff400.gpio", &pioAB_clk)

Got it !
Thanks.

Richard.

-- 
for me, ck means con kolivas and not calvin klein... does it mean I'm a geek ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/