Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757380Ab2HQOWV (ORCPT ); Fri, 17 Aug 2012 10:22:21 -0400 Received: from netrider.rowland.org ([192.131.102.5]:52921 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1756473Ab2HQOWL (ORCPT ); Fri, 17 Aug 2012 10:22:11 -0400 Date: Fri, 17 Aug 2012 10:22:10 -0400 (EDT) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: Hans de Goede cc: "Rafael J. Wysocki" , Miklos Szeredi , Greg Kroah-Hartman , Tejun Heo , , , David Miller Subject: Re: [REGRESION] Suspend hangs with 3.6-rc1 on Lenovo T60 notebook In-Reply-To: <502E0D9D.8070909@redhat.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 995 Lines: 22 On Fri, 17 Aug 2012, Hans de Goede wrote: > No my patch was a hack to undo the results of the commit causing > the regression in the IDE case. But Alan's approach clearly is > much better! Once we are sure drvdata is not used anywhere the > dev_set_drvdata call could be removed in the place where my > hack added a second call to it. Note that there are likely > actual ide drivers using it, without setting it themselves since > the ide core was setting it. So removing it will require even more > auditing / checking. I did search for dev_get_drvdata() calls in drivers/ide; there were no other calls that retrieved an ide_drive_t value. But I didn't check anywhere else in the kernel. In fact, I'm not sure where else to look. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/