Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Tue, 27 Aug 2002 01:46:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Tue, 27 Aug 2002 01:46:39 -0400 Received: from mail.gmx.net ([213.165.64.20]:64624 "HELO mail.gmx.net") by vger.kernel.org with SMTP id ; Tue, 27 Aug 2002 01:46:38 -0400 From: Felix Seeger To: linux-kernel@vger.kernel.org Subject: Re: USB keyboards (patch) Date: Tue, 27 Aug 2002 07:50:49 +0200 User-Agent: KMail/1.4.6 References: <200208270100.09037.nahshon@actcom.co.il> In-Reply-To: <200208270100.09037.nahshon@actcom.co.il> MIME-Version: 1.0 Content-Type: Text/Plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Content-Description: clearsigned data Content-Disposition: inline Message-Id: <200208270750.49576.felix.seeger@gmx.de> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2021 Lines: 61 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Does this Patch solves the kernel panic on startup with USB Mouse plugged in the second usb part and MS Usb keyboard plugged in the first port ? thanks have fun Felix Am Dienstag, 27. August 2002 00:00 schrieb Itai Nahshon: > Vojtech, Would you accept this for the 2.4 kernels? > > The attached patch is required to use some (buggy?) > USB keyboards. IMHO it should not cause new problems > with other HID devices (though, testing with hardware that > I do not have is a good idea). > > I'm using it with recent 2.4 kernels for some time now. > > Just removing the call to usb_set_idle also works (but > it is less efficient). > > The 2.5 kernels do not need this changes - they already call > the equivalent of usb_set_idle (only for input reports) after > reading the first report. > > -- Itai > > --- linux/drivers/usb/hid-core.c.orig Sun Jul 21 01:19:32 2002 > +++ linux/drivers/usb/hid-core.c Sun Jul 21 02:19:31 2002 > @@ -1065,8 +1065,8 @@ > list = report_enum->report_list.next; > while (list != &report_enum->report_list) { > report = (struct hid_report *) list; > - usb_set_idle(hid->dev, hid->ifnum, 0, report->id); > hid_read_report(hid, report); > + usb_set_idle(hid->dev, hid->ifnum, 0, report->id); > list = list->next; > } > } > > > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (GNU/Linux) iD8DBQE9axM5S0DOrvdnsewRApKfAJ9sD2I/61znoiV0MEJXHCjgvNGuVACfRidm 5vdlQPwSXEvzd/TxD4FbI+s= =xkNg -----END PGP SIGNATURE----- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/