Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754904Ab2HRA6s (ORCPT ); Fri, 17 Aug 2012 20:58:48 -0400 Received: from mail-we0-f174.google.com ([74.125.82.174]:49786 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753511Ab2HRA6l (ORCPT ); Fri, 17 Aug 2012 20:58:41 -0400 MIME-Version: 1.0 In-Reply-To: <20120817144253.GA12835@kroah.com> References: <20120817144253.GA12835@kroah.com> Date: Sat, 18 Aug 2012 08:58:39 +0800 Message-ID: Subject: Re: BUG: unable to handle kernel paging request in usb_match_id() From: Ming Lei To: Greg Kroah-Hartman Cc: Alan Stern , Fengguang Wu , =?ISO-8859-1?Q?Bj=F8rn_Mork?= , Oliver Neukum , Sarah Sharp , linux-kernel@vger.kernel.org, "linux-usb@vger.kernel.org" , "Lan, Tianyu" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1203 Lines: 30 On Fri, Aug 17, 2012 at 10:42 PM, Greg Kroah-Hartman wrote: > On Fri, Aug 17, 2012 at 10:38:16AM -0400, Alan Stern wrote: >> On Fri, 17 Aug 2012, Ming Lei wrote: >> >> > But, if HOTPLUG is not enabled, should device_add() trigger driver probe >> > further after kernel init is completed? Or even devices should be allowed >> > to add into system? >> >> Indeed, does it make any sense to have USB support at all if HOTPLUG >> isn't enabled? Should USB select HOTPLUG? > > Well, a long time ago people wanted to use USB but not have HOTPLUG > enabled in their systems for various (odd) embedded systems. As it's > pretty hard to even turn off HOTPLUG these days, I'd be more likely to > just remove CONFIG_HOTPLUG entirely given the dynamic nature of almost > all systems. It should make sense, otherwise all device id table should not use __devinit* markings. There are lots of pci driver usage on it. Thanks, -- Ming Lei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/