Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754768Ab2HRJyj (ORCPT ); Sat, 18 Aug 2012 05:54:39 -0400 Received: from mail-vc0-f174.google.com ([209.85.220.174]:62146 "EHLO mail-vc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753987Ab2HRJyg (ORCPT ); Sat, 18 Aug 2012 05:54:36 -0400 MIME-Version: 1.0 In-Reply-To: <871ujclpqk.fsf@devron.myhome.or.jp> References: <1344743810-2443-1-git-send-email-linkinjeon@gmail.com> <871ujclpqk.fsf@devron.myhome.or.jp> Date: Sat, 18 Aug 2012 18:54:35 +0900 Message-ID: Subject: Re: [PATCH] fat: use accessor function for msdos_dir_entry 'start' From: Namjae Jeon To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Amit Sahrawat , OGAWA Hirofumi Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1563 Lines: 47 2012/8/12, OGAWA Hirofumi : > Namjae Jeon writes: > >> Use accessor function for msdos_dir_entry 'start' > > Acked-by: OGAWA Hirofumi > > Looks good. Thanks. > >> Signed-off-by: Namjae Jeon >> Signed-off-by: Amit Sahrawat >> --- >> fs/fat/dir.c | 6 ++---- >> 1 file changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/fs/fat/dir.c b/fs/fat/dir.c >> index 7b1b9c1..2f3e66e 100644 >> --- a/fs/fat/dir.c >> +++ b/fs/fat/dir.c >> @@ -1143,10 +1143,8 @@ int fat_alloc_new_dir(struct inode *dir, struct >> timespec *ts) >> de[0].ctime_cs = de[1].ctime_cs = 0; >> de[0].adate = de[0].cdate = de[1].adate = de[1].cdate = 0; >> } >> - de[0].start = cpu_to_le16(cluster); >> - de[0].starthi = cpu_to_le16(cluster >> 16); >> - de[1].start = cpu_to_le16(MSDOS_I(dir)->i_logstart); >> - de[1].starthi = cpu_to_le16(MSDOS_I(dir)->i_logstart >> 16); >> + fat_set_start(&de[0], cluster); >> + fat_set_start(&de[1], MSDOS_I(dir)->i_logstart); >> de[0].size = de[1].size = 0; >> memset(de + 2, 0, sb->s_blocksize - 2 * sizeof(*de)); >> set_buffer_uptodate(bhs[0]); > > -- > OGAWA Hirofumi > Hi. Andrew. Would you plz check this patch ? Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/