Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755249Ab2HRNUR (ORCPT ); Sat, 18 Aug 2012 09:20:17 -0400 Received: from mail-vb0-f46.google.com ([209.85.212.46]:39623 "EHLO mail-vb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753495Ab2HRNUN (ORCPT ); Sat, 18 Aug 2012 09:20:13 -0400 MIME-Version: 1.0 In-Reply-To: <1344275476.14513.98.camel@localhost.localdomain> References: <1344275476.14513.98.camel@localhost.localdomain> Date: Sat, 18 Aug 2012 15:20:11 +0200 X-Google-Sender-Auth: z03K1E8eIladX_goj3kpJKJzjpg Message-ID: Subject: Re: [PATCH] m68k: Use PTR_RET rather than if(IS_ERR(.. [1] From: Geert Uytterhoeven To: Thomas Meyer Cc: linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1399 Lines: 43 Thanks, applied and queued for 3.7. On Mon, Aug 6, 2012 at 7:51 PM, Thomas Meyer wrote: > The semantic patch that makes this change is available > in scripts/coccinelle/api/ptr_ret.cocci. > > More information about semantic patching is available at > http://coccinelle.lip6.fr/ > > Signed-off-by: Thomas Meyer > --- > > diff -u -p a/arch/m68k/kernel/time.c b/arch/m68k/kernel/time.c > --- a/arch/m68k/kernel/time.c > +++ b/arch/m68k/kernel/time.c > @@ -100,10 +100,7 @@ static int __init rtc_init(void) > return -ENODEV; > > pdev = platform_device_register_simple("rtc-generic", -1, NULL, 0); > - if (IS_ERR(pdev)) > - return PTR_ERR(pdev); > - > - return 0; > + return PTR_RET(pdev); > } > > module_init(rtc_init); Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/