Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753308Ab2HSJgx (ORCPT ); Sun, 19 Aug 2012 05:36:53 -0400 Received: from mail-vb0-f46.google.com ([209.85.212.46]:35845 "EHLO mail-vb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751073Ab2HSJgu (ORCPT ); Sun, 19 Aug 2012 05:36:50 -0400 MIME-Version: 1.0 In-Reply-To: <1345325159-7365-1-git-send-email-Julia.Lawall@lip6.fr> References: <1345325159-7365-1-git-send-email-Julia.Lawall@lip6.fr> Date: Sun, 19 Aug 2012 13:36:49 +0400 Message-ID: Subject: Re: [PATCH 1/5] drivers/net/wireless/ipw2x00/ipw2100.c: introduce missing initialization From: Stanislav Yakovlev To: Julia Lawall Cc: kernel-janitors@vger.kernel.org, "John W. Linville" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 746 Lines: 25 Hello Julia, On 19 August 2012 01:25, Julia Lawall wrote: > - ipw2100_get_ordinal(priv, IPW_ORD_STAT_ASSN_AP_BSSID, &bssid, &len); > + ret = ipw2100_get_ordinal(priv, IPW_ORD_STAT_ASSN_AP_BSSID, &bssid, > + &len); This is correct, but this line has one more typo. It should be -&bssid +bssid according to the bssid definition in the beginning of the function: u8 bssid[ETH_ALEN]; Could you fix this as well? Thanks! Stanislav. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/