Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754820Ab2HTGcE (ORCPT ); Mon, 20 Aug 2012 02:32:04 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:53153 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754004Ab2HTGcB (ORCPT ); Mon, 20 Aug 2012 02:32:01 -0400 MIME-Version: 1.0 In-Reply-To: <20120819120804.15c33931@pixies.home.jungo.com> References: <1345214124-5478-1-git-send-email-richard.genoud@gmail.com> <1345214124-5478-6-git-send-email-richard.genoud@gmail.com> <20120819120804.15c33931@pixies.home.jungo.com> From: Richard Genoud Date: Mon, 20 Aug 2012 08:31:39 +0200 Message-ID: Subject: Re: [PATCH 5/8] UBI: check max_beb_per1024 value in ubi_attach_mtd_dev To: Shmulik Ladkani Cc: Artem Bityutskiy , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 882 Lines: 26 Hi Shmulik, 2012/8/19 Shmulik Ladkani : > Hi Richard, > > On Fri, 17 Aug 2012 16:35:21 +0200 Richard Genoud wrote: >> + /* >> + * A value of 0 is forced to the default value to keep the same >> + * behavior between ubiattach command and module parameter >> + */ > > Minor thing. > > Since the module parameter is not yet introduced (only in a later > patch), and since last part of sentence isn't that important, I would > simply state: > > + * Use the default if max_beb_per1024 isn't provided. > That's right, I'll correct that in next version. Thanks ! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/