Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755602Ab2HTHiz (ORCPT ); Mon, 20 Aug 2012 03:38:55 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:54470 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751917Ab2HTHix (ORCPT ); Mon, 20 Aug 2012 03:38:53 -0400 MIME-Version: 1.0 In-Reply-To: <20120819122634.252f1ea5@pixies.home.jungo.com> References: <1345214124-5478-1-git-send-email-richard.genoud@gmail.com> <1345214124-5478-7-git-send-email-richard.genoud@gmail.com> <20120819122634.252f1ea5@pixies.home.jungo.com> From: Richard Genoud Date: Mon, 20 Aug 2012 09:38:31 +0200 Message-ID: Subject: Re: [PATCH 6/8] UBI: replace MTD_UBI_BEB_LIMIT with module parameter To: Shmulik Ladkani Cc: Artem Bityutskiy , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1432 Lines: 32 2012/8/19 Shmulik Ladkani : > Hi Richard, > > On Fri, 17 Aug 2012 16:35:22 +0200 Richard Genoud wrote: >> + "MTD devices may be specified by their number, name, or path to the MTD character device node.\n" >> + "Optional \"vid_hdr_offs\" parameter specifies UBI VID header position to be used by UBI. (default value if 0 or not set)\n" >> + "Optional \"max_beb_per1024\" parameter specifies the maximum expected bad eraseblock per 1024 eraseblocks. (default value (" >> + __stringify(CONFIG_MTD_UBI_BEB_LIMIT) ") if 0 or not set)\n" > > Looks like "mtd=/dev/mtd1,,25" is invalid, although we state "default > value if 0 or not set". I'm going to check that. > > Also, lines are exceeding 80 chars, not sure this is more readable than > if they were broken. Actually, I didn't split those lines to make checkpatch happy. Checkpatch.pl doesn't like split strings because they are hard to grep. So there's an exception on the 80 column rule for strings. > > Regards, > Shmulik -- for me, ck means con kolivas and not calvin klein... does it mean I'm a geek ? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/