Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755739Ab2HTIao (ORCPT ); Mon, 20 Aug 2012 04:30:44 -0400 Received: from cantor2.suse.de ([195.135.220.15]:49465 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755465Ab2HTIad (ORCPT ); Mon, 20 Aug 2012 04:30:33 -0400 Date: Mon, 20 Aug 2012 10:30:29 +0200 Message-ID: From: Takashi Iwai To: Andi Kleen Cc: linux-kernel@vger.kernel.org, x86@kernel.org, mmarek@suse.cz, linux-kbuild@vger.kernel.org, JBeulich@suse.com, akpm@linux-foundation.org, Andi Kleen Subject: Re: [PATCH 26/74] lto, sound: Fix export symbols for !CONFIG_MODULES In-Reply-To: <1345345030-22211-27-git-send-email-andi@firstfloor.org> References: <1345345030-22211-1-git-send-email-andi@firstfloor.org> <1345345030-22211-27-git-send-email-andi@firstfloor.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1465 Lines: 49 At Sat, 18 Aug 2012 19:56:22 -0700, Andi Kleen wrote: > > From: Andi Kleen > > The new LTO EXPORT_SYMBOL references symbols even without CONFIG_MODULES. > Since these functions are macros in this case this doesn't work. > Add a ifdef to fix the build. > > Cc: tiwai@suse.de > Signed-off-by: Andi Kleen Reviewed-by: Takashi Iwai I haven't seen the background, so let me ask a dumb question: is it a 3.6 fix or for 3.7? And shall I apply this one to sound git tree, or would you like to apply all in a single tree? thanks, Takashi > --- > sound/core/seq/seq_device.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/sound/core/seq/seq_device.c b/sound/core/seq/seq_device.c > index 5cf8d65..60e8fc1 100644 > --- a/sound/core/seq/seq_device.c > +++ b/sound/core/seq/seq_device.c > @@ -569,5 +569,7 @@ EXPORT_SYMBOL(snd_seq_device_load_drivers); > EXPORT_SYMBOL(snd_seq_device_new); > EXPORT_SYMBOL(snd_seq_device_register_driver); > EXPORT_SYMBOL(snd_seq_device_unregister_driver); > +#ifdef CONFIG_MODULES > EXPORT_SYMBOL(snd_seq_autoload_lock); > EXPORT_SYMBOL(snd_seq_autoload_unlock); > +#endif > -- > 1.7.7.6 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/