Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752754Ab2HTJtl (ORCPT ); Mon, 20 Aug 2012 05:49:41 -0400 Received: from one.firstfloor.org ([213.235.205.2]:59197 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751390Ab2HTJtg (ORCPT ); Mon, 20 Aug 2012 05:49:36 -0400 Date: Mon, 20 Aug 2012 11:49:35 +0200 From: Andi Kleen To: Rusty Russell Cc: Andi Kleen , linux-kernel@vger.kernel.org, x86@kernel.org, mmarek@suse.cz, linux-kbuild@vger.kernel.org, JBeulich@suse.com, akpm@linux-foundation.org, Andi Kleen Subject: Re: [PATCH 27/74] lto: Mark EXPORT_SYMBOL symbols __visible Message-ID: <20120820094935.GD16230@one.firstfloor.org> References: <1345345030-22211-1-git-send-email-andi@firstfloor.org> <1345345030-22211-28-git-send-email-andi@firstfloor.org> <87txvy3vg3.fsf@rustcorp.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87txvy3vg3.fsf@rustcorp.com.au> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 607 Lines: 19 > Really, why? Seems like a win to have them eliminated if unused. > > Naively, I would think many cases of __visible should be #ifdef > CONFIG_MODULES. What am I missing? It worked around some problem I forgot now :) You're right it shouldn't be needed in theory for !MODULES. I'll double check. -Andi -- ak@linux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/