Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756405Ab2HTN54 (ORCPT ); Mon, 20 Aug 2012 09:57:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22187 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756365Ab2HTN5w (ORCPT ); Mon, 20 Aug 2012 09:57:52 -0400 Date: Mon, 20 Aug 2012 09:57:39 -0400 From: Mike Snitzer To: "Martin K. Petersen" Cc: Christoph Hellwig , Shaohua Li , Vivek Goyal , axboe@kernel.dk, linux-kernel@vger.kernel.org, neilb@suse.de, linux-scsi@vger.kernel.org Subject: Re: [patch 1/2]block: handle merged discard request Message-ID: <20120820135739.GB28570@redhat.com> References: <20120320162157.GE17071@redhat.com> <4F69C62C.7020604@kernel.org> <20120620085724.GA26295@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1442 Lines: 33 On Fri, Aug 17 2012 at 11:47pm -0400, Martin K. Petersen wrote: > >>>>> "Mike" == Mike Snitzer writes: > > Mike> Could be I've wasted a few hours by rebasing these patches... > Mike> regardless, it would be great if you could share what your plans > Mike> are. > > Heh, I worked on syncing my patch queue up to Jens' and James' trees > this afternoon. But I didn't quite finish the block stuff, mainly due to > some conflicts with a few topology changes I also have pending. > > I'll take a look at your series. Maybe I'll swap things around and put > the topology changes on top instead of below. Leverage some of the work > you did... OK, just FYI, I had to change bio_has_data() to test bio->bi_vcnt (rather than bio->bi_io_vec != NULL) because a discard bio has a non-NULL bio->bi_io_vec (likely points to the bio->bi_inline_vecs but I didn't check yet). But I haven't put my finger on _why_ a discard bio has bio->bi_io_vec (but given my use of DM, bio comes from bio_alloc_bioset, and DM passes original bio->bi_max_vecs for nr_iovecs). Anyway, this bio_has_data() change seemed reasonable considering bio_data() checks bio->bi_vcnt. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/