Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757051Ab2HTPSe (ORCPT ); Mon, 20 Aug 2012 11:18:34 -0400 Received: from mail-vb0-f46.google.com ([209.85.212.46]:39575 "EHLO mail-vb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756758Ab2HTPSb convert rfc822-to-8bit (ORCPT ); Mon, 20 Aug 2012 11:18:31 -0400 MIME-Version: 1.0 In-Reply-To: <1345474316.9850.4.camel@phoenix> References: <1345465097-31576-1-git-send-email-linus.walleij@stericsson.com> <1345474316.9850.4.camel@phoenix> Date: Mon, 20 Aug 2012 17:18:28 +0200 Message-ID: Subject: Re: [PATCH] regulator: ab8500: fix voltage selector regression From: Linus Walleij To: Axel Lin Cc: Linus Walleij , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org, Mattias Wallin Content-Type: text/plain; charset=Big5 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1100 Lines: 27 On Mon, Aug 20, 2012 at 4:51 PM, Axel Lin wrote: > ?? ?@?A2012-08-20 ?? 14:18 +0200?ALinus Walleij ?????G >> From: Linus Walleij >> >> Commit 3bf6e90e476fb34ca47b6dda270f41d9cebcb1ac >> "regulator: Convert ab8499 to use get_voltage_sel()" >> and commit ae713d394d9e2aacaab620acd3212855f1f06b00 >> "regulator: Convert ab8500 to set_voltage_sel" >> corrupted the voltage selector mechanism is two ways: > > I'm not very sure the commits you mentioned is the root cause, > because it looks that here is no behavior change with both commits. > Does it really work if you revert above commits you mention? No you're right, I've screwed up completely... I confused two codebases. I'll fix a proper patch adding the proper voltage shift fields to the regulator info. Sorry about this Axel! Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/