Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932091Ab2HTRAi (ORCPT ); Mon, 20 Aug 2012 13:00:38 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:50176 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753096Ab2HTRAg (ORCPT ); Mon, 20 Aug 2012 13:00:36 -0400 MIME-Version: 1.0 In-Reply-To: <1345459282-8666-1-git-send-email-makienko@ispras.ru> References: <1345459282-8666-1-git-send-email-makienko@ispras.ru> Date: Mon, 20 Aug 2012 21:00:35 +0400 Message-ID: Subject: Re: [PATCH] staging: octeon: Add prevent NAPI from scheduling From: Max Filippov To: Marina Makienko Cc: Greg Kroah-Hartman , David Daney , Ralf Baechle , "Roy.Li" , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, ldv-project@ispras.ru Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1248 Lines: 34 On Mon, Aug 20, 2012 at 2:41 PM, Marina Makienko wrote: > Code inspection shows that this can > only be triggered by calling napi_enable() without > napi_disable(). > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Marina Makienko > --- > drivers/staging/octeon/ethernet-rx.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c > index 34afc16..db81613 100644 > --- a/drivers/staging/octeon/ethernet-rx.c > +++ b/drivers/staging/octeon/ethernet-rx.c > @@ -560,4 +560,5 @@ void cvm_oct_rx_shutdown(void) > /* Shutdown all of the NAPIs */ > for_each_possible_cpu(i) > netif_napi_del(&cvm_oct_napi[i].napi); > + napi_disable(&cvm_oct_napi[i].napi); > } Looks like napi_disable is meant to be inside for_each_possible_cpu loop, but curly braces are missing. -- Thanks. -- Max -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/