Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755128Ab2HTR3k (ORCPT ); Mon, 20 Aug 2012 13:29:40 -0400 Received: from mx.meyering.net ([88.168.87.75]:44788 "EHLO hx.meyering.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753596Ab2HTR30 (ORCPT ); Mon, 20 Aug 2012 13:29:26 -0400 From: Jim Meyering To: linux-kernel@vger.kernel.org Cc: Jim Meyering , Catalin Marinas , linux-mm@kvack.org Subject: [PATCH] kmemleak: avoid buffer overrun: NUL-terminate strncpy-copied command Date: Mon, 20 Aug 2012 18:55:22 +0200 Message-Id: <1345481724-30108-4-git-send-email-jim@meyering.net> X-Mailer: git-send-email 1.7.12 In-Reply-To: <1345481724-30108-1-git-send-email-jim@meyering.net> References: <1345481724-30108-1-git-send-email-jim@meyering.net> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1211 Lines: 35 From: Jim Meyering strncpy NUL-terminates only when the length of the source string is smaller than the size of the destination buffer. The two other strncpy uses (just preceding) happen to be ok with the current TASK_COMM_LEN (16), because the literals "hardirq" and "softirq" are both shorter than 16. However, technically it'd be better to use strcpy along with a compile-time assertion that they fit in the buffer. Signed-off-by: Jim Meyering --- mm/kmemleak.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/kmemleak.c b/mm/kmemleak.c index 45eb621..947257f 100644 --- a/mm/kmemleak.c +++ b/mm/kmemleak.c @@ -555,6 +555,7 @@ static struct kmemleak_object *create_object(unsigned long ptr, size_t size, * case, the command line is not correct. */ strncpy(object->comm, current->comm, sizeof(object->comm)); + object->comm[sizeof(object->comm) - 1] = 0; } /* kernel backtrace */ -- 1.7.12 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/