Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754294Ab2HTU1w (ORCPT ); Mon, 20 Aug 2012 16:27:52 -0400 Received: from oproxy6-pub.bluehost.com ([67.222.54.6]:38742 "HELO oproxy6-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754172Ab2HTU1s (ORCPT ); Mon, 20 Aug 2012 16:27:48 -0400 Message-ID: <50329DBF.9060206@xenotime.net> Date: Mon, 20 Aug 2012 13:27:43 -0700 From: Randy Dunlap User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110323 Thunderbird/3.1.9 MIME-Version: 1.0 To: Andi Kleen CC: Alan Stern , Andi Kleen , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, greg@kroah.com Subject: Re: [PATCH] USB: Build usb_speed_string unconditionally References: <1345491508-30966-1-git-send-email-andi@firstfloor.org> <20120820195808.GD4461@tassilo.jf.intel.com> In-Reply-To: <20120820195808.GD4461@tassilo.jf.intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Identified-User: {1807:box742.bluehost.com:xenotime:xenotime.net} {sentby:smtp auth 50.53.38.135 authed with rdunlap@xenotime.net} Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 984 Lines: 32 On 08/20/12 12:58, Andi Kleen wrote: > On Mon, Aug 20, 2012 at 03:47:48PM -0400, Alan Stern wrote: >> On Mon, 20 Aug 2012, Andi Kleen wrote: >> >>> From: Andi Kleen >>> >>> The usb core uses usb_speed_string(). But it's only selected >>> for USB_GADGET. Enable it unconditionally. >> >> What are you talking about? USB_COMMON isn't selected at all, but it >> does get built whenever USB or USB_GAGDET is enabled. From >> drivers/usb/Kconfig: > > Just trying to fix my LTO randconfigs. > > Here's a config that violated it on rc2. Involves known problem with DRM_USB AFAICT. Greg just accepted a patch from Guenter Roeck that should fix this: [PATCH RESEND] gpu/mfd/usb: Fix USB randconfig problems -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/