Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754669Ab2HTUms (ORCPT ); Mon, 20 Aug 2012 16:42:48 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:35460 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754172Ab2HTUmp (ORCPT ); Mon, 20 Aug 2012 16:42:45 -0400 Date: Mon, 20 Aug 2012 16:42:44 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Andi Kleen cc: Andi Kleen , , , Subject: Re: [PATCH] USB: Build usb_speed_string unconditionally In-Reply-To: <20120820195808.GD4461@tassilo.jf.intel.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1689 Lines: 41 On Mon, 20 Aug 2012, Andi Kleen wrote: > On Mon, Aug 20, 2012 at 03:47:48PM -0400, Alan Stern wrote: > > On Mon, 20 Aug 2012, Andi Kleen wrote: > > > > > From: Andi Kleen > > > > > > The usb core uses usb_speed_string(). But it's only selected > > > for USB_GADGET. Enable it unconditionally. > > > > What are you talking about? USB_COMMON isn't selected at all, but it > > does get built whenever USB or USB_GAGDET is enabled. From > > drivers/usb/Kconfig: > > Just trying to fix my LTO randconfigs. > > Here's a config that violated it on rc2. Okay, I see the problem. Your config has: # CONFIG_USB_SUPPORT is not set CONFIG_USB=m That combination should not be possible, because in drivers/usb/Kconfig, the definition of USB is inside an "if USB_SUPPORT" block. Runing "make oldconfig" shows that this happened because: warning: (MOUSE_APPLETOUCH && MOUSE_BCM5974 && MOUSE_SYNAPTICS_USB && JOYSTICK_XPAD && TABLET_USB_ACECAD && TABLET_USB_AIPTEK && TABLET_USB_HANWANG && TABLET_USB_KBTAB && TABLET_USB_WACOM && TOUCHSCREEN_USB_COMPOSITE && INPUT_ATI_REMOTE2 && INPUT_KEYSPAN_REMOTE && INPUT_POWERMATE && INPUT_YEALINK && INPUT_CM109 && RC_ATI_REMOTE && IR_IMON && IR_MCEUSB && IR_REDRAT3 && IR_STREAMZAP && IR_IGUANA && DRM_USB) selects USB which has unmet direct dependencies (USB_SUPPORT && USB_ARCH_HAS_HCD) The culprit is DRM_USB, and I think Greg has just accepted a patch to fix it. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/