Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753899Ab2HUHMx (ORCPT ); Tue, 21 Aug 2012 03:12:53 -0400 Received: from mail.free-electrons.com ([88.190.12.23]:56137 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752718Ab2HUHMv (ORCPT ); Tue, 21 Aug 2012 03:12:51 -0400 Message-ID: <503334E9.508@free-electrons.com> Date: Tue, 21 Aug 2012 09:12:41 +0200 From: Gregory CLEMENT User-Agent: Mozilla/5.0 (X11; Linux i686; rv:14.0) Gecko/20120714 Thunderbird/14.0 MIME-Version: 1.0 To: Thomas Petazzoni CC: Sebastian Hesselbarth , Lior Amsalem , Andrew Lunn , Russell King , linux-doc@vger.kernel.org, Linus Walleij , Stephen Warren , linux-kernel@vger.kernel.org, Rob Herring , Grant Likely , Ben Dooks , Rob Landley , devicetree-discuss@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 04/11] pinctrl: mvebu: add pinctrl driver for Armada 370 References: <1344689809-6223-1-git-send-email-sebastian.hesselbarth@gmail.com> <1344689809-6223-5-git-send-email-sebastian.hesselbarth@gmail.com> <50326A60.1070007@gmail.com> <20120820193622.4e539451@skate> In-Reply-To: <20120820193622.4e539451@skate> X-Enigmail-Version: 1.4.3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1636 Lines: 43 On 08/20/2012 07:36 PM, Thomas Petazzoni wrote: > Le Mon, 20 Aug 2012 18:48:32 +0200, > Sebastian Hesselbarth a écrit : > >> this is really difficult here ;) I thought I could just add PINCTRL_DOVE >> to MACH_DOVE inside ARCH_MVEBU, PINCTRL_KIRKWOOD to MACH_KIRKWOOD, aso. >> But there is a common MACH_ARMADA_370_XP for both 370 and XP obviously. >> >> If it is ok for you I will add both PINCTRL_ stubs to the Kconfig and >> you work it out if you ever have two distinct MACHs? Or it could remain >> selectable in pinctrl/Kconfig but that will then be different with the >> other stubs. > > In order to keep the consistency with other SoC families, maybe we can > split the 370 and XP options in two separate MACH_ARMADA_370 and > MACH_ARMADA_XP. So, in the ideal world, once all Marvell EBU SoCs are > converted to DT+mach-mvebu, we should have: > > *) arch/arm/Kconfig defines MACH_MVEBU > > *) arch/arm/mach-mvebu/Kconfig defines MACH_KIRKWOOD, MACH_DOVE, > MACH_MX78X00, MACH_ARMADA_370, MACH_ARMADA_XP, MACH_ORION5X > > Then, an user is free to build a single kernel image that supports all, > or a selection of the supported Marvell EBU SoCs. I agree with Thomas > > Thomas > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/