Date: Tue, 21 Aug 2012 10:00:45 +0200
Message-ID: <s5h1uj08yj6.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Ondrej Zary <linux@rainbow-software.org>
Cc: Massimo Piccioni <dafastidio@libero.it>, alsa-devel@alsa-project.org,
        Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH] snd-als100: fix suspend/resume
In-Reply-To: <201208202150.13593.linux@rainbow-software.org>
References: <201208202150.13593.linux@rainbow-software.org>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.1
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1171
Lines: 44

At Mon, 20 Aug 2012 21:50:13 +0200,
Ondrej Zary wrote:
> 
> snd_card_als100_probe() does not set pcm field in struct snd_sb.
> As a result, PCM is not suspended and applications don't know that they need
> to resume the playback.
> 
> Tested with Labway A381-F20 card (ALS120).
> 
> Signed-off-by: Ondrej Zary <linux@rainbow-software.org>

Applied now.  Thanks.


Takashi

> 
> --- a/sound/isa/als100.c
> +++ b/sound/isa/als100.c
> @@ -233,7 +233,7 @@ static int __devinit snd_card_als100_probe(int dev,
>  			irq[dev], dma8[dev], dma16[dev]);
>  	}
>  
> -	if ((error = snd_sb16dsp_pcm(chip, 0, NULL)) < 0) {
> +	if ((error = snd_sb16dsp_pcm(chip, 0, &chip->pcm)) < 0) {
>  		snd_card_free(card);
>  		return error;
>  	}
> 
> 
> 
> 
> -- 
> Ondrej Zary
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/