Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756507Ab2HUKmf (ORCPT ); Tue, 21 Aug 2012 06:42:35 -0400 Received: from na3sys009aog104.obsmtp.com ([74.125.149.73]:59022 "EHLO na3sys009aog104.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756472Ab2HUKmc (ORCPT ); Tue, 21 Aug 2012 06:42:32 -0400 MIME-Version: 1.0 In-Reply-To: <1345540555-24359-11-git-send-email-balbi@ti.com> References: <1345540555-24359-1-git-send-email-balbi@ti.com> <1345540555-24359-11-git-send-email-balbi@ti.com> From: "Shilimkar, Santosh" Date: Tue, 21 Aug 2012 16:12:11 +0530 Message-ID: Subject: Re: [RFC/PATCH 10/13] serial: omap: stick to put_autosuspend To: Felipe Balbi Cc: alan@linux.intel.com, Tony Lindgren , Kevin Hilman , Linux OMAP Mailing List , Linux ARM Kernel Mailing List , linux-serial@vger.kernel.org, Linux Kernel Mailing List , Shubhrajyoti Datta Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1314 Lines: 34 On Tue, Aug 21, 2012 at 2:45 PM, Felipe Balbi wrote: > Everytime we're done using our TTY, we want > the pm timer to be reinitilized. By sticking > to pm_runtime_pm_autosuspend() we make sure > that this will always be the case. > > Signed-off-by: Felipe Balbi > --- > drivers/tty/serial/omap-serial.c | 33 ++++++++++++++++++++++----------- > 1 file changed, 22 insertions(+), 11 deletions(-) > > diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c > index 6ea24c5..458d77c 100644 > --- a/drivers/tty/serial/omap-serial.c > +++ b/drivers/tty/serial/omap-serial.c > @@ -164,7 +164,8 @@ static void serial_omap_enable_ms(struct uart_port *port) > pm_runtime_get_sync(up->dev); > up->ier |= UART_IER_MSI; > serial_out(up, UART_IER, up->ier); > - pm_runtime_put(up->dev); > + pm_runtime_mark_last_busy(up->dev); > + pm_runtime_put_autosuspend(up->dev); > } > Can you please expand the change-log a bit ? Didn't follow the time re-init part completely. Regards Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/