Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756553Ab2HUKoZ (ORCPT ); Tue, 21 Aug 2012 06:44:25 -0400 Received: from na3sys009aog129.obsmtp.com ([74.125.149.142]:53949 "EHLO na3sys009aog129.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756486Ab2HUKoV (ORCPT ); Tue, 21 Aug 2012 06:44:21 -0400 MIME-Version: 1.0 In-Reply-To: <1345540555-24359-1-git-send-email-balbi@ti.com> References: <1345540555-24359-1-git-send-email-balbi@ti.com> From: "Shilimkar, Santosh" Date: Tue, 21 Aug 2012 16:13:59 +0530 Message-ID: Subject: Re: [RFC/PATCH 00/13] OMAP UART patches To: Felipe Balbi Cc: alan@linux.intel.com, Tony Lindgren , Kevin Hilman , Linux OMAP Mailing List , Linux ARM Kernel Mailing List , linux-serial@vger.kernel.org, Linux Kernel Mailing List , Shubhrajyoti Datta Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1641 Lines: 42 On Tue, Aug 21, 2012 at 2:45 PM, Felipe Balbi wrote: > Hi guys, > > here's a series of cleanup patches to the OMAP serial > driver. A later series could be made re-implementing > DMA using the DMA Engine API. Note that for RX DMA > we could be using RX Timeout IRQ as a hint that we better > use PIO instead ;-) > > All patches were tested on my pandaboard, but I'd really > like to receive Tested-by on other platforms. > > After this goes in, I'll probably try to get UART wakeup > working again and only after that look at DMA. > > cheers > > Felipe Balbi (13): > serial: omap: define and use to_uart_omap_port() > serial: omap: always return IRQ_HANDLED > serial: omap: define helpers for pdata function pointers > serial: omap: don't access the platform_device > serial: omap: drop DMA support > serial: add OMAP-specific defines > serial: omap: simplify IRQ handling > serial: omap: refactor receive_chars() into rdi/rlsi handlers > serial: omap: move THRE check to transmit_chars() > serial: omap: stick to put_autosuspend > serial: omap: set dev->drvdata before enabling pm_runtime > serial: omap: drop unnecessary check from remove > serial: omap: make sure to suspend device before remove > Apart from that one question on last patch, rest of the clean-up is really good. Nice work. FWIW, Acked-by: Santosh Shilimkar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/