Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753966Ab2HULc7 (ORCPT ); Tue, 21 Aug 2012 07:32:59 -0400 Received: from mga01.intel.com ([192.55.52.88]:26790 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753185Ab2HULc6 (ORCPT ); Tue, 21 Aug 2012 07:32:58 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.77,802,1336374000"; d="scan'208";a="183459019" Date: Tue, 21 Aug 2012 12:50:05 +0100 From: Alan Cox To: Felipe Balbi Cc: Tony Lindgren , Kevin Hilman , Linux OMAP Mailing List , Linux ARM Kernel Mailing List , linux-serial@vger.kernel.org, Linux Kernel Mailing List , Santosh Shilimkar , Shubhrajyoti Datta Subject: Re: [RFC/PATCH 02/13] serial: omap: always return IRQ_HANDLED Message-ID: <20120821125005.235926e0@bob.linux.org.uk> In-Reply-To: <1345540555-24359-3-git-send-email-balbi@ti.com> References: <1345540555-24359-1-git-send-email-balbi@ti.com> <1345540555-24359-3-git-send-email-balbi@ti.com> Organization: Intel X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.8; x86_64-redhat-linux-gnu) Organisation: Intel Corporation UK Ltd, registered no. 1134945 (England), Registered office Pipers Way, Swindon, SN3 1RJ Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 594 Lines: 16 On Tue, 21 Aug 2012 12:15:44 +0300 Felipe Balbi wrote: > Even if we enter our IRQ handler just to notice > that the our device didn't generate the IRQ, > that still means "handling" and IRQ, so let's > return IRQ_HANDLED. That looks wrong - you'll defeat the stuck IRQ protection. If we didn't cause the IRQ then we are IRQ_NONE ? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/