Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756989Ab2HULpx (ORCPT ); Tue, 21 Aug 2012 07:45:53 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:36607 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754014Ab2HULpu (ORCPT ); Tue, 21 Aug 2012 07:45:50 -0400 MIME-Version: 1.0 In-Reply-To: <1345545978.23018.104.camel@twins> References: <20120820162237.GA9295@quad> <1345545978.23018.104.camel@twins> Date: Tue, 21 Aug 2012 13:45:48 +0200 Message-ID: Subject: Re: [PATCH] perf/x86: fix SNB-EP CBO and PCU uncore PMU filter management From: Stephane Eranian To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, andi@firstfloor.org, zheng.z.yan@intel.com Content-Type: text/plain; charset=UTF-8 X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1183 Lines: 23 On Tue, Aug 21, 2012 at 12:46 PM, Peter Zijlstra wrote: > On Mon, 2012-08-20 at 18:22 +0200, Stephane Eranian wrote: >> .constraints = snbep_uncore_cbox_constraints, >> .ops = &snbep_uncore_msr_ops, >> .format_group = &snbep_uncore_cbox_format_group, >> + .extra_regs = snbep_uncore_cbo_extra_regs, > > The whole cbo vs cbox thing is a bit unfortunate, I know Intel tends to > forget to type the last letter, but could we be consistent? > > Ideally Intel would have called the thing a Cache Coherence Unit or > somesuch to match the Power Control Unit, But seeing its called C-Box, I > don't see the point of saving the 1 character and obfuscate the name. > I've even seen CBO Box used, which is of course completely ridiculous. Ok, I can resubmit with the word cbox instead. Still missing is the HA box opcode match/mask support. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/