Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753636Ab2HUMCX (ORCPT ); Tue, 21 Aug 2012 08:02:23 -0400 Received: from mail-vb0-f46.google.com ([209.85.212.46]:53623 "EHLO mail-vb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753878Ab2HUMCT (ORCPT ); Tue, 21 Aug 2012 08:02:19 -0400 MIME-Version: 1.0 In-Reply-To: <1345060656-32201-3-git-send-email-thomas.abraham@linaro.org> References: <1345060656-32201-1-git-send-email-thomas.abraham@linaro.org> <1345060656-32201-3-git-send-email-thomas.abraham@linaro.org> Date: Tue, 21 Aug 2012 14:02:18 +0200 Message-ID: Subject: Re: [PATCH v2 2/4] pinctrl: add exynos4210 specific extensions for samsung pinctrl driver From: Linus Walleij To: Thomas Abraham Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, grant.likely@secretlab.ca, rob.herring@calxeda.com, kgene.kim@samsung.com, patches@linaro.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1613 Lines: 48 On Wed, Aug 15, 2012 at 9:57 PM, Thomas Abraham wrote: > Add information about the Exynos4210 pin banks and driver data which is > used by the Samsung pinctrl driver. In addition to this, the support for > external gpio and wakeup interrupt support is included and hooked up with > the Samsung pinctrl driver. OK... > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > +config PINCTRL_EXYNOS4 > + bool "Pinctrl driver data for Exynos4 SoC" > + depends on ARCH_EXYNOS4 && OF Since you depend on PINCTRL_SAMSUNG which depends on OF you don't need to depend on OF here. > + depends on PINCTRL_SAMSUNG > + select PINMUX > + select PINCONF So as noted in the main driver, let PINCTRL_SAMSUNG select PINMUX and PINCONF and you need only select PINCTRL_SAMSUNG here. > diff --git a/drivers/pinctrl/pinctrl-exynos.c b/drivers/pinctrl/pinctrl-exynos.c (...) > +#include > +#include > +#include > +#include Do you need these includes? Didn't you put them all in "pinctrl-samsung.h"? Overall this looks good and straight-forward, but I cannot figure out how the samsung_pinctrl_soc_data is passed to the main driver, it seems to be through some DT node but I cannot figure this out. Can you explain this? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/