Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757221Ab2HUME0 (ORCPT ); Tue, 21 Aug 2012 08:04:26 -0400 Received: from mail-vb0-f46.google.com ([209.85.212.46]:42264 "EHLO mail-vb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757121Ab2HUMEY (ORCPT ); Tue, 21 Aug 2012 08:04:24 -0400 MIME-Version: 1.0 In-Reply-To: <1345060656-32201-5-git-send-email-thomas.abraham@linaro.org> References: <1345060656-32201-1-git-send-email-thomas.abraham@linaro.org> <1345060656-32201-5-git-send-email-thomas.abraham@linaro.org> Date: Tue, 21 Aug 2012 14:04:23 +0200 Message-ID: Subject: Re: [PATCH v2 4/4] ARM: EXYNOS: skip wakeup interrupt setup if pinctrl driver is used From: Linus Walleij To: Thomas Abraham Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, grant.likely@secretlab.ca, rob.herring@calxeda.com, kgene.kim@samsung.com, patches@linaro.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 778 Lines: 25 On Wed, Aug 15, 2012 at 9:57 PM, Thomas Abraham wrote: > Pinctrl driver includes support for configuring the external wakeup > interrupts. On exynos platforms that use pinctrl driver, the setup > of wakeup interrupts in the exynos platform code can be skipped. > > Cc: Kukjin Kim > Signed-off-by: Thomas Abraham > +#ifdef CONFIG_OF Don't you actually want to use: #fidef CONFIG_PINCTRL_SAMSUNG here? CONFIG_OF is a bit vague. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/