Message-ID: <1345556475.5069.3.camel@gandalf.local.home>
Subject: Re: [RFC PATCH -v2 0/4] Persistent events
From: Steven Rostedt <rostedt@goodmis.org>
To: Borislav Petkov <bp@amd64.org>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>
Date: Tue, 21 Aug 2012 09:41:15 -0400
In-Reply-To: <20120821131136.GC21432@aftab.osrc.amd.com>
References: <1345139123-15212-1-git-send-email-bp@amd64.org>
	 <1345545050.23018.95.camel@twins>
	 <20120821131136.GC21432@aftab.osrc.amd.com>
Content-Type: text/plain; charset="ISO-8859-15"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1093
Lines: 35

On Tue, 2012-08-21 at 15:11 +0200, Borislav Petkov wrote:
> On Tue, Aug 21, 2012 at 12:30:50PM +0200, Peter Zijlstra wrote:
> > Good progress there, there's still a few things though:
> > 
> >  - the point also raised by Steven, I'm pretty sure that the placing of
> >    the debugfs files unfortunate. I would much rather see something
> >    like /debug/perf/persistent/$foo, also dropping your
> >    perf_event_desc::dir_name.
> 
> Ok, how do we want to do the per-CPU layout there? Like this:
> 
> /debug/perf/persistent/mce_record0
> /debug/perf/persistent/mce_record1
> ...
> 
> or rather
> 
> /debug/perf/persistent/cpu0/mce_record
> /debug/perf/persistent/cpu1/mce_record
> 
> ?

Definitely the second one. The first one is just ugly. The second is
more in line to the tracing directories too:

/debug/tracing/per_cpu/cpu0/...

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/