MIME-Version: 1.0
In-Reply-To: <alpine.LNX.2.01.1208211204420.1100@frira.zrqbmnf.qr>
References: <1343845147-21394-1-git-send-email-anatol.pomozov@gmail.com>
	<alpine.LNX.2.01.1208211204420.1100@frira.zrqbmnf.qr>
Date: Tue, 21 Aug 2012 06:51:58 -0700
Message-ID: <CAOMFOmW1XZrgHHp+b6s9xjn1iYNqA1ej1KpiyO=KMeCsRgRTzg@mail.gmail.com>
Subject: Re: [PATCH] fs: Preserve error code in get_empty_filp()
From: Anatol Pomozov <anatol.pomozov@gmail.com>
To: Jan Engelhardt <jengelh@inai.de>
Cc: linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk, tytso@mit.edu,
        Anatol Pomazau <anatol@google.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1426
Lines: 41

Hi

On Tue, Aug 21, 2012 at 3:06 AM, Jan Engelhardt <jengelh@inai.de> wrote:
>
>
> On Wednesday 2012-08-01 20:19, anatol.pomozov@gmail.com wrote:
> >Allocating a file structure in function get_empty_filp() might fail
> > because
> >of several reasons:
> > - not enough memory for file structures
> > - operation is not allowed
> > - user is over its limit
> >
> >Currently the function returns NULL in all cases and we loose the exact
> >reason of the error. All callers of get_empty_filp() assume that the
> > function
> >can fail with ENFILE only.
> >
> >Return error through pointer. Change all callers to preserve this error
> > code.
>
> >       percpu_counter_inc(&nr_files);
> >       f->f_cred = get_cred(cred);
> >-      if (security_file_alloc(f))
> >+      if (security_file_alloc(f)) {
> >+              error = -EPERM;
> >               goto fail_sec;
> >+      }
>
> You are not preserving the error code from security_file_alloc here.
>
> In particular, apparmoar/lsm.c: file_alloc_security can return -ENOMEM,
> for example.

Yep, this was a bug in the first version of the patch. It the latest
version (from Aug 2) it is fixed, please review this version instead.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/