Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755647Ab2HUPl4 (ORCPT ); Tue, 21 Aug 2012 11:41:56 -0400 Received: from tx2ehsobe004.messaging.microsoft.com ([65.55.88.14]:31682 "EHLO tx2outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751904Ab2HUPly (ORCPT ); Tue, 21 Aug 2012 11:41:54 -0400 X-Forefront-Antispam-Report: CIP:163.181.249.108;KIP:(null);UIP:(null);IPV:NLI;H:ausb3twp01.amd.com;RD:none;EFVD:NLI X-SpamScore: -3 X-BigFish: VPS-3(zz98dI1432Izz1202hzz15d4Iz2dh668h839h944hd25he5bhf0ah11b5h) X-WSS-ID: 0M943LM-01-AAW-02 X-M-MSG: Date: Tue, 21 Aug 2012 17:41:46 +0200 From: Joerg Roedel To: Konrad Rzeszutek Wilk CC: , , , Suresh Siddha , Yinghai Lu Subject: Re: [PATCH 17/19] x86, msi: Introduce x86_msi.compose_msi_msg call-back Message-ID: <20120821154146.GN2582@amd.com> References: <1345470965-24410-1-git-send-email-joerg.roedel@amd.com> <1345470965-24410-18-git-send-email-joerg.roedel@amd.com> <20120820140843.GA7732@phenom.dumpdata.com> <20120821084007.GL2582@amd.com> <20120821144256.GC20097@phenom.dumpdata.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20120821144256.GC20097@phenom.dumpdata.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-OriginatorOrg: amd.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1462 Lines: 36 On Tue, Aug 21, 2012 at 10:42:57AM -0400, Konrad Rzeszutek Wilk wrote: > On Tue, Aug 21, 2012 at 10:40:07AM +0200, Joerg Roedel wrote: > > On Mon, Aug 20, 2012 at 10:08:44AM -0400, Konrad Rzeszutek Wilk wrote: > > > On Mon, Aug 20, 2012 at 03:56:03PM +0200, Joerg Roedel wrote: > > > > This call-back points to the right function for initializing > > > > the msi_msg structure. > > > > > > What is the 'hpet_id' purpose in this? > > > > The VT-d implementation uses it. This function is used to create the MSI > > message for PCI devices and the HPET. When it is called for the HPET the > > pdev parameter is NULL and hpet_id is valid. > > Perhaps then a more generic term? 'void *platform_priv' ? Well, the best approach is probably to remove both, the pdev and the hpet parameter and replace it with an req_id parameter that is passed down instead. IOMMU code needs to expose the hpet request-ids then with another call-back. But that is cleaner than the current compose_msi_msg call-back. Joerg -- AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/